Skip to content

lint: Start to use py lint scripts - #24762

Merged
maflcko merged 2 commits into
bitcoin:masterfrom
maflcko:2204-lint-with-py-🥂
Apr 5, 2022

Hidden character warning

The head ref may contain hidden characters: "2204-lint-with-py-\ud83e\udd42"
Merged

lint: Start to use py lint scripts #24762
maflcko merged 2 commits into
bitcoin:masterfrom
maflcko:2204-lint-with-py-🥂

Conversation

@maflcko

@maflcko maflcko commented Apr 4, 2022

Copy link
Copy Markdown
Member

No description provided.

@laanwj

laanwj commented Apr 4, 2022

Copy link
Copy Markdown
Member

Yess, concept ACK.

@fanquake

fanquake commented Apr 4, 2022

Copy link
Copy Markdown
Member

Concept ACK

@fjahr

fjahr commented Apr 4, 2022

Copy link
Copy Markdown
Contributor

tACK fae211c

Reviewed code and took it for a spin with #24766. Didn't see any issues.

mini-nit: lint-files.sh is still mentioned in the test readme but I can also take care of that in the follow-up 494e991

@DrahtBot

DrahtBot commented Apr 4, 2022

Copy link
Copy Markdown
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #24435 (test: Refactor subtree exclusion in lint tests by maxraustin)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@maflcko
maflcko merged commit 4262100 into bitcoin:master Apr 5, 2022
@maflcko
maflcko deleted the 2204-lint-with-py-🥂 branch April 5, 2022 06:45
@bitcoin bitcoin locked and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants