build: No longer need to hack the PATH variable in config.site - #24866
Merged
Conversation
Member
|
Nice. Concept ACK! |
Contributor
|
Concept ACK 32995a8 + builds cleanly on my system. |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
hebasto
marked this pull request as ready for review
April 16, 2022 06:35
This was referenced Apr 16, 2022
Contributor
|
Concept ACK Guix hashes (x86), mine match @hebasto: |
Member
|
Concept ACK. It would be good to get the DMG removal in first. |
Member
Author
Converting to draft until #24031 goes first. |
hebasto
marked this pull request as draft
April 17, 2022 15:20
Member
hebasto
marked this pull request as ready for review
April 21, 2022 08:08
This change makes naming of `install_name_tool` consistent across the whole build system. -BEGIN VERIFY SCRIPT- sed --in-place --expression='s/INSTALLNAMETOOL/INSTALL_NAME_TOOL/g' $(git grep --files-with-matches 'INSTALLNAMETOOL') -END VERIFY SCRIPT-
Now all of the tools have well-defined absolute paths to them.
Member
Author
Member
Author
|
Guix builds hashes have been updated in the PR description. |
Member
|
Tested ACK efa3a80. I get the same build output as in OP: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds lacking definitions of absolute paths to some tools in the depends build system.
This improvement makes possible to keep the
PATHvariable untouched during configuration.Also see #24566 (comment).
Guix builds on
x86_64: