rpc, wallet: add abandoned field for all categories of transaction in ListTransaction

[brunoerg]

Fixes #25130

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

No conflicts as of last run.

[jonatack]

Quick readover of the code as a break from seminar readings, but a key point would be to consider why this field was not returned other than for sent txns (and if concept ACKs, ensure there is appropriate test coverage in the tests that assert on this field. Quick grep:)

test/functional/feature_backwards_compatibility.py:197:                        assert not(txs[1]["abandoned"])
test/functional/feature_backwards_compatibility.py:200:                        assert txs[3]["abandoned"]
test/functional/wallet_abandonconflict.py:197:            assert_equal(tx["abandoned"], False)
test/functional/wallet_abandonconflict.py:202:        assert_equal(double_spend["abandoned"], False)
test/functional/wallet_abandonconflict.py:131:            assert_equal(tx['abandoned'], True)

[brunoerg]

a key point would be to consider why this field was not returned other than for sent txns

I couldn't find any resources about it, i'd like to understand more, btw Concept NACKs are welcome! I find #7739 which added this field but there is no explanation about why it is only in send.

[brunoerg]

Force-pushed addressing @jonatack's comments

[achow101]

Are you still working on this?

[brunoerg]

Are you still working on this?

Yes.

[achow101]

ACK efdb80a69000572a5f36fc702090da99c627238d

I think it's reasonable to output this for all transactions, even if we decide that one type cannot be abandoned. A trivial case where this is useful are send-to-self transactions as these show up as individual send and receive transactions.

[maflcko]

You will have to modify the RPC docs for gettransaction as well

[brunoerg]

You will have to modify the RPC docs for gettransaction as well

Nice find, thanks! Force-pushed modifying it.

[achow101]

re-ACK 0c52067