Skip to content

doc: Fix typo in importdescriptors - #25276

Merged
maflcko merged 1 commit into
bitcoin:masterfrom
KolbyML:patch-13
Jun 6, 2022
Merged

doc: Fix typo in importdescriptors#25276
maflcko merged 1 commit into
bitcoin:masterfrom
KolbyML:patch-13

Conversation

@KolbyML

@KolbyML KolbyML commented Jun 5, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 210cd59

@Zeyu-Li

Zeyu-Li commented Jun 5, 2022

Copy link
Copy Markdown

lgtm

@LarryRuane LarryRuane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 210cd59

@DrahtBot

DrahtBot commented Jun 5, 2022

Copy link
Copy Markdown
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #25110 (tidy: use modernize-use-raw-string-literal by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@brunoerg brunoerg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crACK 210cd59

@brunoerg

brunoerg commented Jun 5, 2022

Copy link
Copy Markdown
Contributor

You could fix all typos in this PR.

See:

src/kernel/context.h:15: libary ==> library
src/net.cpp:1106: Desig ==> Design
src/net.cpp:1107: Desig ==> Design
src/net.cpp:1108: Desig ==> Design
src/net.cpp:1109: Desig ==> Design
src/net.cpp:1110: Desig ==> Design
src/net.cpp:1111: Desig ==> Design
src/net.cpp:1112: Desig ==> Design
src/net.cpp:1113: Desig ==> Design
src/net.cpp:1114: Desig ==> Design
src/net.cpp:1115: Desig ==> Design
src/net.cpp:1116: Desig ==> Design
src/net.cpp:1117: Desig ==> Design
src/util/designator.h:16: Desig ==> Design
src/util/designator.h:18: Desig ==> Design

@hebasto

hebasto commented Jun 5, 2022

Copy link
Copy Markdown
Member

You could fix all typos in this PR.

See:

src/kernel/context.h:15: libary ==> library
src/net.cpp:1106: Desig ==> Design
src/net.cpp:1107: Desig ==> Design
src/net.cpp:1108: Desig ==> Design
src/net.cpp:1109: Desig ==> Design
src/net.cpp:1110: Desig ==> Design
src/net.cpp:1111: Desig ==> Design
src/net.cpp:1112: Desig ==> Design
src/net.cpp:1113: Desig ==> Design
src/net.cpp:1114: Desig ==> Design
src/net.cpp:1115: Desig ==> Design
src/net.cpp:1116: Desig ==> Design
src/net.cpp:1117: Desig ==> Design
src/util/designator.h:16: Desig ==> Design
src/util/designator.h:18: Desig ==> Design

I think Desig is a correct macro's name :)

@brunoerg

brunoerg commented Jun 5, 2022

Copy link
Copy Markdown
Contributor

I think Desig is a correct macro's name :)

nice, we could add it to spelling.ignore-words.txt

@maflcko
maflcko merged commit e82d806 into bitcoin:master Jun 6, 2022
@bitcoin bitcoin locked and limited conversation to collaborators Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants