guix: Remove librt usage from release binaries - #28069
Merged
fanquake merged 3 commits intoJul 17, 2023
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Member
|
Concept ACK. |
Member
|
Concept ACK. IIRC we left this because it was harmless as most systems kept a stub for librt. I suppose the situation has now inverted and relying on the stub is deprecated? (Also, it's possible I'm mixed up and thinking of libm or similar) |
Member
Confirming. From https://www.man7.org/linux/man-pages/man3/clock_gettime.3.html:
|
Member
|
Guix builds: |
Contributor
hebasto
approved these changes
Jul 13, 2023
Contributor
|
Guix builds: |
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Feb 1, 2024
Summary: > contrib: remove librt from release deps > guix: backport glibc patch to prevent redundant librt link This is a backport of [[bitcoin/bitcoin#28069 | core#28069]] Depends on D15345 Test Plan: gitian builds `contrib/guix/guix-build` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D15346
HiHat
added a commit
to HiHat/pocketnet.core
that referenced
this pull request
Feb 21, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our release binaries currently have a runtime dependency on
librt. However this is redundant, and only the case due to a bug in glibc. Theclock_*suit of funcs were absorbed into libc long ago, however an issue with compatibility code meant that librt would still be linked against / used redundantly:This PR drops our configure check for librt (which is redundant, and could be PR'd standalone), and backports the relevant patch into our glibc, so we can drop librt from our runtime dependencies.
Guix Build: