[29.x] Backports - #32292
Merged
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32292. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
Member
|
Could also add #32184 ? |
fanquake
force-pushed
the
29_x_backports
branch
from
April 17, 2025 11:52
bb237be to
98425be
Compare
hebasto
reviewed
Apr 17, 2025
fanquake
force-pushed
the
29_x_backports
branch
2 times, most recently
from
April 17, 2025 14:13
9e59b78 to
ae2a3fd
Compare
Contributor
Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use] |
fanquake
force-pushed
the
29_x_backports
branch
from
April 24, 2025 14:12
ae2a3fd to
818bcba
Compare
Member
|
Could also include bitcoin-core/gui#864, possibly? |
Member
+1 |
fanquake
force-pushed
the
29_x_backports
branch
from
April 28, 2025 09:00
818bcba to
3011fc2
Compare
fanquake
force-pushed
the
29_x_backports
branch
from
April 28, 2025 09:57
3011fc2 to
45fbcda
Compare
Member
|
It seems |
fanquake
force-pushed
the
29_x_backports
branch
from
April 28, 2025 10:10
45fbcda to
757c29f
Compare
Contributor
|
🚧 At least one of the CI tasks failed. HintsTry to run the tests locally, according to the documentation. However, a CI failure may still
Leave a comment here, if you need help tracking down a confusing failure. |
This hardware feature is - rarely supported on SoCs (and broken on like half of the chips that support it in the first place) (bitcoin#31817) - apparently not compiled into the release binary (bitcoin#31817 (comment)) - hard to test in CI, due to unavailable of hardware Better to remove it. This reverts commit aee5404. Closes bitcoin#31817. Github-Pull: bitcoin#32248 Rebased-From: 7749d92
Github-Pull: bitcoin#32286 Rebased-From: a4041c7
This change is necessary for Windows GHA images, which provide CMake >= 4.0. Github-Pull: bitcoin#32184 Rebased-From: ef00a28
The mempool_monitor tracing tool is incorrectly reading the reason as the first argument. Fix this! Github-Pull: bitcoin#32454 Rebased-From: 31c5ebc
This can alsofail to compile when optimisations are being used, see: bitcoin#31913. So disable just ASan for this function under any optimisation level. Github-Pull: bitcoin#32437 Rebased-From: 4e8ab5e
This change makes the `WITH_DBUS` option available on all Unix-like systems, not just Linux, thereby fixing a regression that was overlooked during the migration from Autotools. Note: Enabling D-Bus support on macOS still makes no sense, since the `Notificator` class uses the User Notification Center regardless. Github-Pull: bitcoin#32469 Rebased-From: 5b7ed46
Fix incorrect variable name in comment (nTimes -> nTime) in feature_pruning.py. This typo caused the test to always reset mine_large_blocks.nTime to 0, rather than only on the first run as intended. Github-Pull: bitcoin#32312 Rebased-From: 772ba7f
After fixing the nTime variable name, the test_pruneheight_undo_presence test began failing because node 2, which is involved in reorg testing, could be on a different chain than other nodes. This caused failures when trying to fetch blocks from other nodes that didn't recognize node 2's chain. Switch to using node 5 instead, which is also a pruned node but isn't involved in reorg testing, ensuring it stays on the same chain as the other nodes. This allows the block fetching to work as intended in the test. Github-Pull: bitcoin#32312 Rebased-From: 2aa63d5
There could be a race with outstanding TxAddedToMempool notifications being applied to the soon-to-be created wallet. Fixes an intermittent timeout reproducable by adding a sleep to AddToWallet. Github-Pull: bitcoin#32483 Rebased-From: 07350e2
During init, the test framework will start using rpc after the mempool was loaded. It will not wait for postInitProcess or outstanding transactionAddedToMempool notifications, leading to a possible race, in which listunspent is being called while the tx is still in Inactive status. Prevent this by processing outstanding notifications. Github-Pull: bitcoin#32483 Rebased-From: e7ad86e
Logging the wallet version before anything has been read from disk results in the wrong version being logged. Also split the last client version logging as it may not always be present to be logged. Github-Pull: bitcoin#32553 Rebased-From: 359ecd3
Github-Pull: bitcoin#32553 Rebased-From: 39a483c
Github-Pull: bitcoin#32553 Rebased-From: 4b2cd0b
willcl-ark
approved these changes
May 21, 2025
willcl-ark
left a comment
willcl-ark
left a comment
Member
There was a problem hiding this comment.
crACK a0d1f69
Checked all patches were backported cleanly and appear in the release notes.
Did not build/test.
morozow
pushed a commit
to morozow/bitcoin_rd
that referenced
this pull request
May 8, 2026
8d5b2ae doc: update release notes for 29.x (fanquake) b732ce3 test: check that creating a wallet does not log version info (Ava Chow) b91d4be test: Check that the correct versions are logged on wallet load (Ava Chow) ba0038d walletdb: Log the wallet version after it has been read from disk (Ava Chow) fc5f95f test: fix another intermittent failure in wallet_basic.py (Martin Zumsande) be619f2 test: Fix intermittent failure in wallet_basic.py (Martin Zumsande) 17304ab test: Use uninvolved pruned node in feature_pruning undo test (enoch) a346ad2 test: Fix nTimes typo in feature_pruning test (enoch) 60e0346 cmake: Allow `WITH_DBUS` on all Unix-like systems (Hennadii Stepanov) 09b4e4a crypto: disable ASan for sha256_sse4 with Clang (fanquake) cabc6d4 tracing: fix invalid argument in mempool_monitor (William Casarin) b1b01c2 cmake: Respect user-provided configuration-specific flags (Hennadii Stepanov) ee1830b doc: Fix test_bitcoin path (monlovesmango) 22a6fac doc: Fix fuzz test_runner.py path (monlovesmango) f2cf3dc qt: Replace stray tfm::format to cerr with qWarning (laanwj) c40b867 gui: crash fix, disconnect numBlocksChanged() signal during shutdown (furszy) 778f435 scripted-diff: Use bpf_cflags (MarcoFalke) e684171 test: Add imports for util bpf_cflags (MarcoFalke) b49b823 refactor: Remove spurious virtual from final ~CZMQNotificationInterface (MarcoFalke) f0a9d5d ci: Add workaround for vcpkg's libevent package (Hennadii Stepanov) 720cc3a test: Handle empty string returned by CLI as None in RPC tests (Brandon Odiwuor) e0fb860 Remove support for RNDR/RNDRRS for aarch64 on Linux (laanwj) Pull request description: Backports for `29.x`: - bitcoin#32184 - bitcoin#32187 - bitcoin#32248 - bitcoin#32286 - bitcoin#32312 - bitcoin#32336 - bitcoin#32353 - bitcoin#32356 - bitcoin#32389 - bitcoin#32437 - bitcoin#32454 - bitcoin#32469 - bitcoin#32483 - bitcoin#32553 - bitcoin-core/gui#864 - bitcoin-core/gui#868 ACKs for top commit: willcl-ark: crACK 8d5b2ae Tree-SHA512: 72aafd17348aa4b602661efd07d48c6af6637c7349e7b032a65f46364e50094723d1c80dced71f0d5ddec59d6dafb72f0463944413a4d810a35cdca6b8272780
ivanlele
added a commit
to ivanlele/elements
that referenced
this pull request
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports for
29.x:libeventpackage #32184-Wduplicate-decl-specifierin bpfcc #32336WITH_DBUSon all Unix-like systems #32469