wallet: Identify transactions spending 0-value outputs, and add tests for anchor outputs in a wallet - #33268

achow101 · 2025-08-28T22:28:48Z

One of the ways that the wallet would determine if a transaction was sent from the wallet was by checking if the total amount being spent by a transaction from outputs known to the wallet was greater than 0. This has worked fine until recently since there was no reason for 0-value outputs to be created. However, with ephemeral dust and P2A, it is possible to create standard 0-value outputs, and the wallet was not correctly identifying the spends of such outputs. This PR updates IsFromMe to only check whether the wallet knows any of the inputs, rather than checking the debit amount of a transaction.

Additionally, a new functional test is added to test for this case, as well as a few other anchor output related scenarios. This also revealed a bug in sendall which would cause an assertion error when trying to spend all of the outputs in a wallet that has anchor outputs.

Fixes #33265

DrahtBot · 2025-08-28T22:28:53Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33268.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	rkrux, enirox001, furszy
Stale ACK	jsarenik, w0xlt, kannapoix

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#31615 (validation: ensure assumevalid is always used during reindex by Eunovo)
#27865 (wallet: Track no-longer-spendable TXOs separately by achow101)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot · 2025-08-28T22:52:28Z

🚧 At least one of the CI tasks failed.
_{Task lint: https://github.com/bitcoin/bitcoin/runs/49140364057}
_{LLM reason (✨ experimental): Lint failure (py_lint) due to an unused import in test_wallet_anchor.py (CTransaction) flagged by ruff.}

Hints

Try to run the tests locally, according to the documentation. However, a CI failure may still
happen due to a number of reasons, for example:

Possibly due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the
affected test.
An intermittent issue.

Leave a comment here, if you need help tracking down a confusing failure.

jsarenik · 2025-08-29T08:00:29Z

Tested ACK 7d1c3ce7f0f0. I have compiled it and ran the script from issue #33265 with no output other than the current UTC date. Works for me.

Thanks!

jsarenik · 2025-08-29T12:09:41Z

After it gets merged into master branch, I would recommend backporting it to current stable release branch which already contains the ephemeral outputs support (29.x).

instagibbs · 2025-08-29T13:04:00Z

@jsarenik technically this issue could happen if miners mine 0-value outputs of any kind, but given that it's now relay-possible, seems like a good idea to backport

jsarenik · 2025-08-30T18:53:48Z

Tested ACK de98ffb

furszy

q: is IsFromMe() method still relevant? It seems we could directly call IsMine() on the inputs, which is also cached now and should be slightly safer for migration.

achow101 · 2025-08-31T18:31:10Z

is IsFromMe() method still relevant?

Yes, transactions that we make are still treated specially.

furszy · 2025-08-31T18:59:22Z

is IsFromMe() method still relevant?

Yes, transactions that we make are still treated specially.

Where?. IsFromMe() seems to be only ever called in AddToWalletIfInvolvingMe() and ApplyMigrationData() next to the IsMine() call. In both places we effectively treat it as is_mine = IsMine(outputs) || IsFromMe(inputs).

achow101 · 2025-08-31T19:30:06Z

Where?

Hmm, I forgot that CachedTxIsFromMe does not use IsFromMe. Might need to change that in this PR as well.

achow101 · 2025-09-01T22:50:40Z

Hmm, I forgot that CachedTxIsFromMe does not use IsFromMe. Might need to change that in this PR as well.

I've pulled in 2 commits from #27865 which drop CachedTxIsFromMe and replace it with an IsFromMe check which is stored on disk.

In both places we effectively treat it as is_mine = IsMine(outputs) || IsFromMe(inputs).

While that's true, moving IsFromMe into IsMine does change IsMine's semantics in other places, so I'm not sure that that would necessarily be correct. I think it would be better to explore that in a different PR.

DrahtBot · 2025-09-01T23:06:24Z

🚧 At least one of the CI tasks failed.
_{Task lint: https://github.com/bitcoin/bitcoin/runs/49358785571}
_{LLM reason (✨ experimental): Lint Python code failure: unused variable fee in test_wallet_listtransactions.py (F841).}

Hints

Try to run the tests locally, according to the documentation. However, a CI failure may still
happen due to a number of reasons, for example:

Possibly due to a silent merge conflict (the changes in this pull request being
incompatible with the current code in the target branch). If so, make sure to rebase on the latest
commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the
affected test.
An intermittent issue.

Leave a comment here, if you need help tracking down a confusing failure.

w0xlt · 2025-09-02T18:49:12Z

nit: perhaps it makes review easier.

Suggested change

wallet = self.nodes[0].get_wallet_rpc("fromme")

fromme_wallet = self.nodes[0].get_wallet_rpc("fromme")

fanquake · 2026-01-13T09:44:45Z

Backported to 29.x in #34268.

If something is imported into the wallet, it can change the 'from me' status of a transaction. This status is only visible through gettransaction's "fee" field which is only shown for transactions that are 'from me'. Github-Pull: bitcoin#33268 Rebased-From: e76c2f7

Instead of checking whether the total amount of inputs known by the wallet is greater than 0, we should be checking for whether the input is known by the wallet. This enables us to determine whether a transaction spends an of output with an amount of 0, which is necessary for marking 0-value dust outputs as spent. Github-Pull: bitcoin#33268 Rebased-From: 39a7dbd

Github-Pull: bitcoin#33268 Rebased-From: c40dc82

Github-Pull: bitcoin#33268 Rebased-From: 609d265

If something is imported into the wallet, it can change the 'from me' status of a transaction. This status is only visible through gettransaction's "fee" field which is only shown for transactions that are 'from me'. Github-Pull: bitcoin#33268 Rebased-From: e76c2f7

Instead of checking whether the total amount of inputs known by the wallet is greater than 0, we should be checking for whether the input is known by the wallet. This enables us to determine whether a transaction spends an of output with an amount of 0, which is necessary for marking 0-value dust outputs as spent. Github-Pull: bitcoin#33268 Rebased-From: 39a7dbd

Github-Pull: bitcoin#33268 Rebased-From: c40dc82

m_cached_from_me is used to track whether a transaction is "from me", i.e. has any inputs which belong to the wallet. This is held in memory only in the same way that a transaction's balances are. Github-Pull: bitcoin#33268 Rebased-From: 113a422

b834447 [doc] generate manpages 29.3rc1 (glozow) e9c9783 [build] bump version to 29.3rc1 (glozow) e973b61 [doc] update release notes for 29.3rc1 (glozow) f4b78c4 test: Add a test for anchor outputs in the wallet (Ava Chow) c6e7765 wallet: Throw an error in sendall if the tx size cannot be calculated (Ava Chow) bab1ac8 wallet: Determine IsFromMe by checking for TXOs of inputs (Ava Chow) 71633a9 test: Test wallet 'from me' status change (Ava Chow) daef585 guix: Fix `osslsigncode` tests (Hennadii Stepanov) 7a71850 Remove unreliable seed from chainparams.cpp, and the associated README (SatsAndSports) 2e46886 miner: fix `addPackageTxs` unsigned integer overflow (ismaelsadeeq) Pull request description: Backports: - #34227 - #33723 - #33475 - #33268 And final changes for 29.3rc1 ACKs for top commit: achow101: ACK b834447 janb84: ACK b834447 sedited: ACK b834447 Tree-SHA512: 68e02fbde7162f728229f4bfc803bedda6d269e54593ebe40da607f6bd25b2b10bc4297bfa0bc977ce2dc6b558efe6571a7f875090e0f916fc09e5b67432ba30

If something is imported into the wallet, it can change the 'from me' status of a transaction. This status is only visible through gettransaction's "fee" field which is only shown for transactions that are 'from me'. Github-Pull: bitcoin#33268 Rebased-From: afed5f7

Instead of checking whether the total amount of inputs known by the wallet is greater than 0, we should be checking for whether the input is known by the wallet. This enables us to determine whether a transaction spends an of output with an amount of 0, which is necessary for marking 0-value dust outputs as spent. Github-Pull: bitcoin#33268 Rebased-From: aae427c

Github-Pull: bitcoin#33268 Rebased-From: 4212b7c

Github-Pull: bitcoin#33268 Rebased-From: 7b1f54d

m_cached_from_me is used to track whether a transaction is "from me", i.e. has any inputs which belong to the wallet. This is held in memory only in the same way that a transaction's balances are. Github-Pull: bitcoin#33268 Rebased-From: 71136c5

6b222a3 cmake: Install `bitcoin` manpage (Hennadii Stepanov) 6d44e0e net: Do not apply whitelist permission to onion inbounds (Martin Zumsande) 5357c58 test: Add submitblock test in interface_ipc (TheCharlatan) 8247fdd test: Prevent disk space warning during node_init_tests (Ryan Ofsky) 609a121 ci: Enable CI_LIMIT_STACK_SIZE=1 in i686_no_ipc task (MarcoFalke) f492aec test: Fix CLI_MAX_ARG_SIZE issues (MarcoFalke) 393b45d cmake: Fix regression in `secp256k1.cmake` (Hennadii Stepanov) a4874b8 wallet: Add m_cached_from_me to cache "from me" status (Ava Chow) c831d6a test: Add a test for anchor outputs in the wallet (Ava Chow) 0d311f7 wallet: Throw an error in sendall if the tx size cannot be calculated (Ava Chow) bd80dc7 wallet: Determine IsFromMe by checking for TXOs of inputs (Ava Chow) 19da90f test: Test wallet 'from me' status change (Ava Chow) 6b1d3da trace: Workaround GCC bug compiling with old systemtap (Luke Dashjr) b776b2e ci: always use tag for LLVM checkout (fanquake) 7c96632 gui: Avoid pathological QT text/markdown behavior... (David Gumberg) Pull request description: Backports: * bitcoin#33243 * bitcoin#33268 * bitcoin#33310 * bitcoin#33364 * bitcoin#33379 * bitcoin#33380 * bitcoin#33391 * bitcoin#33407 * bitcoin-core/gui#886 ACKs for top commit: darosior: utACK 6b222a3 hebasto: ACK 6b222a3, I applied all backports locally without conflicts and obtained a zero diff with this PR branch. Tree-SHA512: 257cc5bd0423fbf2aff62c72957faea3de8731353d809b11e18d0e5cad174c7023dca9dedd0c73e07497eb804b7c48355a055b4461db260e2f0a5712d2514ff6

If something is imported into the wallet, it can change the 'from me' status of a transaction. This status is only visible through gettransaction's "fee" field which is only shown for transactions that are 'from me'. Github-Pull: bitcoin#33268 Rebased-From: afed5f7

DrahtBot added the Wallet label Aug 28, 2025

achow101 force-pushed the zero-value-from-me branch 2 times, most recently from bae350c to 7d1c3ce Compare August 28, 2025 22:52

DrahtBot added the CI failed label Aug 28, 2025

DrahtBot removed the CI failed label Aug 29, 2025

instagibbs reviewed Aug 29, 2025

View reviewed changes

Comment thread src/wallet/wallet.cpp Outdated

Comment thread test/functional/wallet_anchor.py Outdated

fanquake added the Needs backport (29.x) label Aug 29, 2025

fanquake mentioned this pull request Aug 29, 2025

[29.x] finalise v29.1 #33271

Merged

DrahtBot mentioned this pull request Aug 29, 2025

validation: ensure assumevalid is always used during reindex #31615

Closed

achow101 force-pushed the zero-value-from-me branch from 7d1c3ce to de98ffb Compare August 29, 2025 19:55

furszy reviewed Aug 31, 2025

View reviewed changes

achow101 force-pushed the zero-value-from-me branch from de98ffb to c33734f Compare September 1, 2025 22:50

achow101 force-pushed the zero-value-from-me branch from c33734f to e201a1e Compare September 1, 2025 23:06

DrahtBot added the CI failed label Sep 1, 2025

DrahtBot removed the CI failed label Sep 2, 2025

This was referenced Sep 2, 2025

wallet: Store transactions in a separate sqlite table #33034

Draft

wallet: Replace CWalletTx::mapValue and vOrderForm with explicit class members #32763

Merged

w0xlt reviewed Sep 2, 2025

View reviewed changes

DrahtBot mentioned this pull request Sep 2, 2025

wallet: Track no-longer-spendable TXOs separately #27865

Open

glozow mentioned this pull request Jan 12, 2026

[29.x] backports + final changes for 29.3 #34268

Merged

fanquake removed the Needs backport (29.x) label Jan 13, 2026

glozow pushed a commit to glozow/bitcoin that referenced this pull request Jan 14, 2026

wallet: Throw an error in sendall if the tx size cannot be calculated

c6e7765

Github-Pull: bitcoin#33268 Rebased-From: c40dc82

glozow pushed a commit to glozow/bitcoin that referenced this pull request Jan 14, 2026

test: Add a test for anchor outputs in the wallet

f4b78c4

Github-Pull: bitcoin#33268 Rebased-From: 609d265

sedited pushed a commit to sedited/bitcoin that referenced this pull request Jan 14, 2026

wallet: Throw an error in sendall if the tx size cannot be calculated

aaf046c

Github-Pull: bitcoin#33268 Rebased-From: c40dc82

morozow pushed a commit to morozow/bitcoin_rd that referenced this pull request May 8, 2026

wallet: Throw an error in sendall if the tx size cannot be calculated

0d311f7

Github-Pull: bitcoin#33268 Rebased-From: 4212b7c

morozow pushed a commit to morozow/bitcoin_rd that referenced this pull request May 8, 2026

test: Add a test for anchor outputs in the wallet

c831d6a

Github-Pull: bitcoin#33268 Rebased-From: 7b1f54d

	wallet = self.nodes[0].get_wallet_rpc("fromme")
	fromme_wallet = self.nodes[0].get_wallet_rpc("fromme")

Uh oh!

Conversation

achow101 commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage & Benchmarks

Reviews

Conflicts

Uh oh!

DrahtBot commented Aug 28, 2025

Uh oh!

jsarenik commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsarenik commented Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

instagibbs commented Aug 29, 2025

Uh oh!

jsarenik commented Aug 30, 2025

Uh oh!

furszy left a comment

Choose a reason for hiding this comment

Uh oh!

achow101 commented Aug 31, 2025

Uh oh!

furszy commented Aug 31, 2025

Uh oh!

achow101 commented Aug 31, 2025

Uh oh!

achow101 commented Sep 1, 2025

Uh oh!

DrahtBot commented Sep 1, 2025

Uh oh!

w0xlt Sep 2, 2025

Choose a reason for hiding this comment

Uh oh!

fanquake commented Jan 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

achow101 commented Aug 28, 2025 •

edited

Loading

DrahtBot commented Aug 28, 2025 •

edited

Loading

jsarenik commented Aug 29, 2025 •

edited

Loading

jsarenik commented Aug 29, 2025 •

edited

Loading