Async load prompt - #771
Closed
Ankur Goyal (ankrgyl) wants to merge 6 commits into
Closed
Conversation
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| :param api_key: The API key to use. If the parameter is not specified, will try to use the `BRAINTRUST_API_KEY` environment variable. If no API | ||
| key is specified, will prompt the user to login. | ||
| :param org_name: (Optional) The name of a specific organization to connect to. This is useful if you belong to multiple. | ||
| :param project_id: The id of the project to load the prompt from. This takes precedence over `project` if specified. |
Contributor
There was a problem hiding this comment.
The project_id parameter documentation appears twice in this function - once at line 1498 and again here at line 1507. This duplicate documentation should be removed to maintain clarity in the API documentation.
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Ankur Goyal (ankrgyl)
requested a review
from Manu Goyal (manugoyal)
as a code owner
July 6, 2025 02:51
Manu Goyal (manugoyal)
approved these changes
Jul 8, 2025
Manu Goyal (manugoyal)
left a comment
Manu Goyal (manugoyal)
left a comment
Contributor
There was a problem hiding this comment.
lgtm. Matt Perpick (@clutchski) do you know if there's a reasonable way to test this in the SDK repo itself? Do we have a mock for the data plane API or something (or should we add one)?
| long_description = f.read() | ||
|
|
||
| install_requires = [ | ||
| "aiohttp", |
Contributor
There was a problem hiding this comment.
is this necessary if we're dynamic importing it?
Member
|
Closing this as we've moved the python SDK code out of this repo, but we are tracking it with this GitHub issue: #771 |
Mahhheshh (Mahhheshh)
added a commit
to Mahhheshh/braintrust-sdk-python
that referenced
this pull request
Mar 15, 2026
ankur's work from braintrustdata/braintrust-sdk-javascript#771 Co-authored-by: Mahhheshh <100200105+Mahhheshh@users.noreply.github.com>
Mahhheshh (Mahhheshh)
added a commit
to Mahhheshh/braintrust-sdk-python
that referenced
this pull request
Mar 15, 2026
ankur's work from braintrustdata/braintrust-sdk-javascript#771 Co-authored-by: Mahhheshh <100200105+Mahhheshh@users.noreply.github.com>
Mahhheshh (Mahhheshh)
added a commit
to Mahhheshh/braintrust-sdk-python
that referenced
this pull request
Mar 25, 2026
ankur's work from braintrustdata/braintrust-sdk-javascript#771 Co-authored-by: Mahhheshh <100200105+Mahhheshh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.