Fix popover aria semantics on macOS Sequoia and improve "Show whitespace changes?" accessibility - #19518
Merged
sergiou87 merged 3 commits intoNov 12, 2024
Conversation
tidy-dev
approved these changes
Nov 12, 2024
tidy-dev
left a comment
tidy-dev
left a comment
Contributor
There was a problem hiding this comment.
✨ Thank you for contending with macOS's annoying inconsistent support for screen reader labeling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xref. https://github.com/github/accessibility-audits/issues/8592
Description
This PR fixes the aria attributes of popovers on macOS Sequoia (not needed for dialogs though) and adds the labelledby/describedby aria attributes to the "Show whitespace changes?" popover.
Screenshots
CleanShot.2024-11-07.at.17.24.00.mp4
Release notes
Notes: [Fixed] Add aria-labelledby and aria-describedby attributes to "Show whitespace changes?" popover