Skip to content

ci: Tighten /format command trigger conditions - #201

Merged
ascorbic merged 4 commits into
emdash-cms:mainfrom
erezrokah:claude/serene-banzai
Apr 3, 2026
Merged

ci: Tighten /format command trigger conditions#201
ascorbic merged 4 commits into
emdash-cms:mainfrom
erezrokah:claude/serene-banzai

Conversation

@erezrokah

@erezrokah erezrokah commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Tighten /format command trigger conditions

Type of change

  • Bug fix
  • Feature (requires approved Discussion)
  • Refactor (no behavior change)
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • I have read CONTRIBUTING.md
  • pnpm typecheck passes
  • pnpm --silent lint:json | jq '.diagnostics | length' returns 0
  • pnpm test passes (or targeted tests for my change)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • I have added a changeset (if this PR changes a published package)
  • New features link to an approved Discussion: https://github.com/emdash-cms/emdash/discussions/...

AI-generated code disclosure

  • This PR includes AI-generated code

Screenshots / test output

Use exact match and add author_association check for the /format
comment command workflow.
@changeset-bot

changeset-bot Bot commented Apr 3, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c12c6ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@erezrokah
erezrokah marked this pull request as ready for review April 3, 2026 21:13
Copilot AI review requested due to automatic review settings April 3, 2026 21:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Tightens the GitHub Actions /format comment-command workflow so it triggers only on an exact /format comment and only when posted by trusted repository-associated users.

Changes:

  • Switches the trigger condition from substring match to exact match on github.event.comment.body == '/format'.
  • Adds an author_association gate allowing only MEMBER, OWNER, or COLLABORATOR to trigger the job.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@erezrokah

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Apr 3, 2026
@erezrokah erezrokah changed the title chore: Tighten /format command trigger conditions ci: Tighten /format command trigger conditions Apr 3, 2026

@ascorbic ascorbic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Erez!

@pkg-pr-new

pkg-pr-new Bot commented Apr 3, 2026

Copy link
Copy Markdown

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/@emdash-cms/admin@201

@emdash-cms/auth

npm i https://pkg.pr.new/@emdash-cms/auth@201

@emdash-cms/blocks

npm i https://pkg.pr.new/@emdash-cms/blocks@201

@emdash-cms/cloudflare

npm i https://pkg.pr.new/@emdash-cms/cloudflare@201

emdash

npm i https://pkg.pr.new/emdash@201

create-emdash

npm i https://pkg.pr.new/create-emdash@201

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/gutenberg-to-portable-text@201

@emdash-cms/x402

npm i https://pkg.pr.new/@emdash-cms/x402@201

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-moderation@201

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/@emdash-cms/plugin-atproto@201

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/@emdash-cms/plugin-audit-log@201

@emdash-cms/plugin-color

npm i https://pkg.pr.new/@emdash-cms/plugin-color@201

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/@emdash-cms/plugin-embeds@201

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/@emdash-cms/plugin-forms@201

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/@emdash-cms/plugin-webhook-notifier@201

commit: c12c6ce

@ascorbic
ascorbic enabled auto-merge (squash) April 3, 2026 21:54
@ascorbic
ascorbic merged commit 85b3d1a into emdash-cms:main Apr 3, 2026
20 of 21 checks passed
wardvisual pushed a commit to wardvisual/emdash that referenced this pull request Apr 6, 2026
@erezrokah
erezrokah deleted the claude/serene-banzai branch April 6, 2026 19:07
wardvisual pushed a commit to wardvisual/emdash that referenced this pull request Apr 12, 2026
wardvisual pushed a commit to wardvisual/emdash that referenced this pull request Jul 5, 2026
wardvisual pushed a commit to wardvisual/emdash that referenced this pull request Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants