Skip to content

feat: Add DeleteCodeQLDatabase for code scanning - #4421

Merged
gmlewis merged 1 commit into
google:masterfrom
kyungseopk1m:feat/delete-codeql-database
Jul 31, 2026
Merged

feat: Add DeleteCodeQLDatabase for code scanning#4421
gmlewis merged 1 commit into
google:masterfrom
kyungseopk1m:feat/delete-codeql-database

Conversation

@kyungseopk1m

Copy link
Copy Markdown
Contributor

Fixes #4419

Adds CodeScanningService.DeleteCodeQLDatabase for DELETE /repos/{owner}/{repo}/code-scanning/codeql/databases/{language}.

The endpoint returns 204 with no body, so the method returns (*Response, error) and passes nil to Do, matching RepositoriesService.DeleteHook.

The operation is already present in openapi_operations.yaml, so go generate ./... produces no changes.

One thing worth flagging for a follow up: the scope sentences on the neighboring ListCodeQLDatabases and GetCodeQLDatabase say security_events, but the current OpenAPI description for all three of these operations says repo or public_repo. I left those two alone to keep this PR to a single endpoint.

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.54%. Comparing base (34349a8) to head (d9c10fe).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4421   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files         194      194           
  Lines       19765    19771    +6     
=======================================
+ Hits        19279    19285    +6     
  Misses        268      268           
  Partials      218      218           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jul 29, 2026
@gmlewis gmlewis changed the title feat: Add DeleteCodeQLDatabase for code scanning feat: Add DeleteCodeQLDatabase for code scanning Jul 29, 2026

@gmlewis gmlewis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @kyungseopk1m!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @Not-Dhananjay-Mishra

@Not-Dhananjay-Mishra Not-Dhananjay-Mishra left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Jul 31, 2026
@gmlewis
gmlewis merged commit dcc5410 into google:master Jul 31, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add DeleteCodeQLDatabase to CodeScanningService

3 participants