chore: Add github action to update discovery artifacts - #1187
Conversation
google-cla
Bot
added
the
cla: yes
f2adaac to
4d02b9c
Compare
bcoe
left a comment
bcoe
left a comment
There was a problem hiding this comment.
Left a few drive by comments 👍
I'm excited to see if this works for you.
dbf53cc to
0a470c7
Compare
b661e1b to
19d12ae
Compare
parthea
removed
the
do not merge
c8f9cfe to
3925e46
Compare
|
@tswast @busunkim96 This is ready for review. Please can you take a look? |
parthea
left a comment
parthea
left a comment
There was a problem hiding this comment.
I highlighted code that was added for testing purposes and will be removed before merging the PR.
busunkim96
left a comment
busunkim96
left a comment
There was a problem hiding this comment.
LGTM. What decision was made regarding detecting breaking changes?
After discussion with @danoscarmike, there will be no changes to the semver major version for this PR as we cannot definitively determine breaking changes. This PR only provides a summary of the changes that occurred in terms of key/value pairs. Any new keys will trigger a minor bump as the commit messages will still have |
|
Thanks for reviewing @tswast ! I've moved the scripts to a new PR #1286 in an attempt to merge the scripts to master before the Github Action is added. Please continue the review in #1286. I'll make sure to address the comments that you've added so far in this PR and make the changes in #1286. I'm also going to work on adding tests for the scripts in #1286. |
|
@busunkim96 @tswast @SurferJeffAtGoogle @JustinBeckwith This is ready for review. PTAL |
|
@bcoe PTAL |
7 participants
This PR adds a Github Actions script to copy the discovery artifacts from googleapis/discovery-artifact-manager and create a PR which summarizes the changes.
PR #1286 contains the scripts that the Github Action will use.