chore: add scripts to update discovery artifacts - #1286
Merged
gcf-merge-on-green[bot] merged 28 commits intoApr 21, 2021
Merged
Conversation
google-cla
Bot
added
the
cla: yes
parthea
marked this pull request as draft
April 7, 2021 18:25
parthea
changed the title
parthea
force-pushed
the
add-scripts-for-updating-discovery-artifacts-using-github-action
branch
3 times, most recently
from
April 8, 2021 19:51
377735a to
a92b5ad
Compare
parthea
changed the title
parthea
marked this pull request as ready for review
April 8, 2021 19:52
parthea
force-pushed
the
add-scripts-for-updating-discovery-artifacts-using-github-action
branch
2 times, most recently
from
April 11, 2021 12:22
dfb5856 to
dad7255
Compare
Contributor
Author
|
@busunkim96 @tswast This is ready for review. PTAL. |
tswast
approved these changes
Apr 20, 2021
tswast
left a comment
tswast
left a comment
There was a problem hiding this comment.
Looks good! A few nits re: pathlib vs os, but feel free to ignore / stick with os.
parthea
force-pushed
the
add-scripts-for-updating-discovery-artifacts-using-github-action
branch
from
April 21, 2021 12:55
500040b to
8c25e1f
Compare
Contributor
Author
|
@tswast All comments have been addressed. PTAL |
parthea
added
the
automerge
gcf-merge-on-green
Bot
deleted the
add-scripts-for-updating-discovery-artifacts-using-github-action
branch
April 21, 2021 15:00
gcf-merge-on-green
Bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These PR add the scripts from #1187 that are needed to update discovery artifacts using a Github action. The scripts will be removed from #1187 once all of the review comments from #1187 have been resolved.
This PR adds the following files under the
scripts/folderREADME.mdto provide instructions on manually updating discovery artifacts and API reference documentation.buildprbody.pycreates a summary of the changes detected in discovery artifacts and writes them toallapis.summary.changesummary.pycreates verbose change information for each API with discovery artifact changes.createcommits.shcreates git commits for each API with discovery artifact changes or reference document changes.updatediscoveryartifacts.pyis the python file that can be used to update discovery artifacts.I also moved
describe.pyunder the scripts folder and modified it to save the discovery artifacts that are fetched.TODO: