Skip to content

Remove print thead rule - #101

Merged
roblarsen merged 2 commits into
h5bp:masterfrom
mattbrundage:patch-3
Jan 21, 2021
Merged

Remove print thead rule#101
roblarsen merged 2 commits into
h5bp:masterfrom
mattbrundage:patch-3

Conversation

@mattbrundage

Copy link
Copy Markdown
Contributor

The thead rule is safe to remove -- it was a workaround for browsers that didn't conform to this part of the CSS 2.1 spec. (https://www.w3.org/TR/CSS21/tables.html#table-display)
In practice, this meant IE 6 & IE 7.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

The ``thead`` rule is safe to remove -- it was a workaround for browsers that didn't conform to this part of the CSS 2.1 spec. (https://www.w3.org/TR/CSS21/tables.html#table-display)
In practice, this meant IE 6 & IE 7.
@roblarsen
roblarsen merged commit 5b37a83 into h5bp:master Jan 21, 2021
@coliff coliff mentioned this pull request Feb 16, 2021
3 tasks
XhmikosR pushed a commit to twbs/bootstrap that referenced this pull request Jul 8, 2021
The `thead` rule is safe to remove -- it was a workaround for browsers that didn't conform to this part of the CSS 2.1 spec. (https://www.w3.org/TR/CSS21/tables.html#table-display)
In practice, this meant IE 6 & IE 7.

(thanks to @mattbrundage for this PR upstream for the main.css project (h5bp/main.css#101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants