Updates phpmyadmin to use 5.2.1 - #39
Merged
Merged
Conversation
👷 Deploy request for lando-phpmyadmin pending review.Visit the deploys page to approve it
|
Member
|
Thanks for the contribution @SpiralBrad! I think you'll also want to add a test to the examples directory; you can simply modify the existing 5.0 test to include a 5.2 service instance, and test that instance with commands in the Leia test file LMK if you need more guidance! |
Closed
Contributor
Author
|
@reynoldsalec / etc... try this now. Passes the leia tests it seems like. |
AaronFeledy
approved these changes
Dec 14, 2024
Contributor
Author
|
What is this |
Member
|
Thanks for the ping @SpiralBrad, sorry I missed your earlier comment. That docs test fails because it's not able to build a version of the docs from your repo...we can ignore that. Thanks for your work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this all that is needed to use the latest 5.2.1 docker image? Untested...
Re: #38