Add adaptive card UI for Dev Box - #154
Conversation
| // See example Response: https://learn.microsoft.com/en-us/rest/api/devcenter/developer/dev-boxes/start-dev-box?view=rest-devcenter-developer-2023-04-01&tabs=HTTP | ||
| var operationId = Guid.Parse(operationLocation!.Segments.Last()); | ||
|
|
||
| _log.Information($"Adding Dev Box '{DisplayName}' with to OperationMonitor"); |
There was a problem hiding this comment.
Doesn't make sense. Did you mean to add another variable here?
There was a problem hiding this comment.
yea "with" should not be here, should just be "to"
| public string PoolName { get; set; } = string.Empty; | ||
|
|
||
| public string DevBoxName { get; set; } = string.Empty; | ||
| public string NewEnvironmentName { get; set; } = string.Empty; |
There was a problem hiding this comment.
NIT: Should just use the consistent DevBox nomenclature.
There was a problem hiding this comment.
Actually this is used because in Dev Home we have no way of know the name of the compute system the user is attempting to create based on the CreateComputeSystemOperation. See this comment in Dev Home where I explain it a bit more: https://github.com/microsoft/devhome/blob/4559792e7c6c0e62a4da32bbd32011c4fe4c4a20/common/Environments/Models/CreateComputeSystemOperation.cs#L69
| public async Task<List<DevBoxProjectAndPoolContainer>> GetAllProjectsToPoolsMappingAsync(JsonElement projectsJson, IDeveloperId developerId) | ||
| public async Task<List<DevBoxProjectAndPoolContainer>> GetAllProjectsToPoolsMappingAsync(DevBoxProjects projects, IDeveloperId developerId) | ||
| { | ||
| var uniqueUserId = $"{developerId.LoginId}#{developerId.Url}"; |
There was a problem hiding this comment.
Curious: Why isn't the login id unique enough here and above?
There was a problem hiding this comment.
Now that the azure extension supports multiple accounts, users can have the same email across multiple accounts. So using the login Url is added to make it more unique. It is a best practice suggested by Vineeth
| </data> | ||
| <data name="DevBox_ReviewPageNameLabel" xml:space="preserve"> | ||
| <value>Name{0}</value> | ||
| <comment>Label text for textbox where users will enter the name for their Dev Box</comment> |
There was a problem hiding this comment.
Should you add locked{0} here?
4 participants
Summary of the pull request
A Supplemental PR into Dev Home needs to be submitted first before checking this in: microsoft/devhome#2639
This PR adds DevBox creation UI to the Azure extension and changes the following:
CreationForm.jsonandReviewForm.json. The first will be sent as the initial page. When the user selects the next button in Dev Home the review page will be sent. If the user selects the previous button the creation page will be sent. If the user is on the review page and selects next we capture their input, stop the session and send it back to Dev Home. Dev Home will them re-show the review page back to the user once creation of the Dev Box has begun.Video of flow:
DevBoxCreationInDevHome.mp4
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist