This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Finish UI for environments creation - #2539
Merged
Merged
Conversation
…aby/add-hyper-v-code-for-creation-adaptive-cards
…ds' into user/bbonaby/add-initial-creation-flow-in-setup-flow
…p after moving to a different page
…om holding onto items view control internally
…aby/add-hyper-v-code-for-creation-adaptive-cards
…ds' into user/bbonaby/add-initial-creation-flow-in-setup-flow
…ds' into user/bbonaby/finish-ui-for-environments-creation
…nto user/bbonaby/finish-ui-for-environments-creation
bbonaby
requested review from
AmelBawa-msft,
SohamDas2021,
dhoehna,
huzaifa-d,
jsidewhite,
kanismohammed,
krschau and
sshilov7
April 5, 2024 17:04
sshilov7
reviewed
Apr 5, 2024
|
|
||
| public Exception Exception { get; } | ||
|
|
||
| public event TypedEventHandler<ICreateComputeSystemOperation, CreateComputeSystemProgressEventArgs> Progress = (s, e) => { }; |
Member
There was a problem hiding this comment.
This hurts my eyes as it's completely unnecessary.
Contributor
Author
There was a problem hiding this comment.
Interestingly stylecop is the reason for this one. I think it might be time to standardize which stylecop errors we care about or not in Dev Home.
sshilov7
reviewed
Apr 5, 2024
dhoehna
reviewed
Apr 5, 2024
sshilov7
reviewed
Apr 5, 2024
sshilov7
reviewed
Apr 5, 2024
| { | ||
| var repoConfigTasksTotal = _setupFlowOrchestrator.GetTaskGroup<RepoConfigTaskGroup>()?.CloneTasks.Count ?? 0; | ||
| var appManagementTasksTotal = _setupFlowOrchestrator.GetTaskGroup<AppManagementTaskGroup>()?.SetupTasks.Count() ?? 0; | ||
| if (_setupFlowOrchestrator.IsSettingUpATargetMachine && repoConfigTasksTotal == 0 && appManagementTasksTotal == 0) |
Member
There was a problem hiding this comment.
Coding guidelines: "Use parentheses to make clauses in an expression apparent".
This is in Windows C++ guidelines and in C# Common code conventions.
sshilov7
approved these changes
Apr 5, 2024
bbonaby
changed the base branch from
user/bbonaby/add-initial-creation-flow-in-setup-flow
to
main
April 5, 2024 23:21
bbonaby
changed the base branch from
main
to
user/bbonaby/add-initial-creation-flow-in-setup-flow
April 5, 2024 23:21
…is made when you click the create environment button
bbonaby
changed the base branch from
user/bbonaby/add-initial-creation-flow-in-setup-flow
to
main
April 6, 2024 01:34
6 tasks
huzaifa-d
approved these changes
Apr 9, 2024
huzaifa-d
left a comment
Contributor
There was a problem hiding this comment.
Looked at it from a high level as it's quite long.
| public static async Task CopyToAsync(this Stream source, Stream destination, IProgress<ByteTransferProgress> progressProvider, int bufferSize, long totalBytesToExtract, CancellationToken cancellationToken) | ||
| { | ||
| var buffer = new byte[bufferSize]; | ||
| long totalRead = 0; |
|
|
||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Linq; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
This PR is PR 4 of 4 that completes the create environment flow in machine configuration flow and the UI to show the operation progress in the Environments page. It allows us to start the create compute system operation provided by an extension, keep track of the operation and show progress of the operation in the UI.
Please see previous PRs for context:
Things added:
Here is a small video of the flow up to the start of the archive extraction
Video.Showing.start.of.creation.flow.from.Environments.page.mp4
Here is a small video of the flow when the archive extraction from the Hyper-V extension starts taking place.:
Video.showing.update.messages.from.the.hyper-v.extension.when.its.extracting.a.file.mp4
References and relevant issues
Design/PM wanted the cards that show progress to always stay at the top of the UI. To do that I'd have to change the way we sort the cards. I didn't have time to change it so I'll create an issue to track that work as a bug fix
We also want to give the users the ability to switch accounts e.g azure accounts in both the environment and setup target page. Currently we only show the first account, I'll create another issue to address that as a bug fix.
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist