Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Allow SSH widget to show entries with multiple Host aliases - #2664

Merged
krschau merged 2 commits into
microsoft:mainfrom
gohellp:patch-1
Jun 7, 2024
Merged

Allow SSH widget to show entries with multiple Host aliases#2664
krschau merged 2 commits into
microsoft:mainfrom
gohellp:patch-1

Conversation

@gohellp

@gohellp gohellp commented Apr 17, 2024

Copy link
Copy Markdown
Contributor

Summary of the pull request

Changes to Regexp to support writing from multiple Host aliases

References and relevant issues

#2646

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

@krschau

krschau commented Apr 18, 2024

Copy link
Copy Markdown
Collaborator

As part of this, it would be great if you could update our sample config (https://github.com/microsoft/devhome/blob/main/extensions/CoreWidgetProvider/Widgets/Assets/example_config) to include the kind of host you're fixing this for.

@gohellp

gohellp commented Apr 18, 2024

Copy link
Copy Markdown
Contributor Author

@microsoft-github-policy-service agree

@krschau

krschau commented Jun 3, 2024

Copy link
Copy Markdown
Collaborator

Adding "do-not-merge" while I check something on our end.

@krschau krschau added Do-Not-Merge Don't merge this in yet and removed Do-Not-Merge Don't merge this in yet labels Jun 3, 2024
@krschau krschau changed the title fix issue microsoft/devhome#2646 Allow SSH widget to show entries with multiple Host aliases Jun 7, 2024
@EricJohnson327

Copy link
Copy Markdown
Contributor

Closing and reopening to try to trigger builds.

@EricJohnson327 EricJohnson327 reopened this Jun 7, 2024
@krschau
krschau merged commit 71c6700 into microsoft:main Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSH widget does not show hosts with multi-word alias names

4 participants