Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Refactoring winget/dsc services out of UI projects - #3134

Merged
AmelBawa-msft merged 43 commits into
mainfrom
user/amelbawa/services
Jun 26, 2024
Merged

Refactoring winget/dsc services out of UI projects#3134
AmelBawa-msft merged 43 commits into
mainfrom
user/amelbawa/services

Conversation

@AmelBawa-msft

@AmelBawa-msft AmelBawa-msft commented Jun 5, 2024

Copy link
Copy Markdown
Contributor

Summary of the pull request

References and relevant issues

  • Moved Windows Package Manager to a new csproj
  • Decoupled DSC from Windows Package Manager and promoted to a separate csproj
  • Rename IAppInstallManagerService to IMicrosoftStoreService
  • Rename IWindowsPackageManager to IWinGet
  • Use Microsoft.Extensions.Logging.ILogger instead of Serilog.ILogger in DevHome.Services.*
  • Restructure DSC into services instead of a single helper file
graph TB;
    %%{init:{'flowchart':{"defaultRenderer": "elk"}}}%%
    subgraph Services["\n\n\n\nService projects:\n- UI agnostic\n- Mockable\n- Reusable"]
        Core
        WPM
        DSC
    end

    Core[Core]
    WPM[WindowsPackageManager]
    DSC[DesiredStateConfiguration]
    SF[SetupFlow]
    SFE[SetupFlowElevated]
    Common[Common]
    
    WPM --> Core
    DSC --> Core
    SF --> WPM
    SF --> DSC    
    SFE --> WPM
    SFE --> DSC
    Common --> Core
Loading

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

Comment thread common/DevHome.Common.csproj
Comment thread services/DevHome.Services.Core/Services/MicrosoftStoreService.cs
@AmelBawa-msft AmelBawa-msft changed the title Refactoring winget services out of UI projects Refactoring winget/dsc services out of UI projects Jun 14, 2024
@krschau

krschau commented Jun 21, 2024

Copy link
Copy Markdown
Collaborator

You might want to rebase instead of merge... looks like your PR has pulled in previous changes, making it harder to see what changed here.

@krschau krschau left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest moving new stuff under Common in a separate change.
Also, you might want to create Debug_FailFast configs for the new projects

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename DevHome.SetupFlow.PackageCatalog to PackageCollection Refactor and share code between elevated and dev home processes

5 participants