This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Use Hyper-V group SID instead of displayname to support other localizations - #3373
Merged
Merged
Conversation
bbonaby
approved these changes
Jul 8, 2024
krschau
approved these changes
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Update of the HyerVSetupScript to use the SID instead of the display name of the "Hyper-V Administrators" group to support other localizations.
References and relevant issues
Resolves #3128
Detailed description of the pull request / Additional comments
Validation steps performed
My Windows uses the german localization.
I build it locally and added my useraccount successfully to the group via DevHome.
PR checklist