Allow empty labels array to be pushed to set-labels to remove all of them - #4637
Merged
Alex Ross (alexr00) merged 1 commit intoMar 17, 2023
Merged
Conversation
Alex Ross (alexr00)
enabled auto-merge (squash)
March 17, 2023 08:57
Alex Ross (alexr00)
approved these changes
Mar 17, 2023
Alex Ross (alexr00)
left a comment
Alex Ross (alexr00)
left a comment
Member
There was a problem hiding this comment.
Thanks for the fix!
Ulugbek Abdullaev (ulugbekna)
approved these changes
Mar 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #4634
If there are no checked labels from the quick pick menu, the command
set-labelsis not posted, preventing the possibility to remove all (the last one) selected labels.I didn’t remove the if because
labelsToAddcan be undefined if the menu is closed with esc, but the length control is causing the bug hence should be removed.