Fix wrong repo URL for nested repos in workspace (fix copy permalink) - #4711
Merged
Merged
Conversation
Alex Ross (alexr00)
approved these changes
Apr 12, 2023
Alex Ross (alexr00)
left a comment
Alex Ross (alexr00)
left a comment
Member
There was a problem hiding this comment.
Looks good, thank you for the fix!
Alex Ross (alexr00)
enabled auto-merge (squash)
April 12, 2023 13:23
Megan Rogge (meganrogge)
approved these changes
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example I have workspace which contains git repos in below locations:
When I'm editing
/foo/bar/abc.tsx,getManagerForFile()returns the Manager of/foo, not/foo/bar.So I get wrong repo URL in "Copy GitHub permalink":
https://github.com/test-user/foo-bar/blob/...https://github.com/test-user/foo/blob/...With this PR,
getManagerForFile()returns/foo/barfor above case.Note this PR affects other features like issue number completion:
/foo)/foo/bar)