fix: limit vLLM VAD segments to 30 seconds - #3420
Merged
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The server constructed FSMN-VAD without
max_single_segment_time, so it inherited the 60-second default. Passing this value toAutoModel.generate()is ineffective because FSMN-VAD stores it inVADXOptionsat model construction time.On the 480-second attachment from #3419, a 60-second segment omitted a substantial passage around the Blackwell/product update and robot discussion. The 30-second configuration matches the existing Fun-ASR-Nano examples and documentation.
Validation
python3 -m pytest tests/test_fun_asr_nano_autocast_device.py tests/test_fun_asr_nano_ctc_batch_fallback.py tests/test_fun_asr_nano_missing_ctc_weights.py tests/test_fun_asr_nano_openai_response.py tests/test_fun_asr_nano_repetition_penalty.py -q(27 passed)python3 -m py_compile examples/industrial_data_pretraining/fun_asr_nano/serve_vllm.py tests/test_fun_asr_nano_openai_response.pypython3 -m black --check tests/test_fun_asr_nano_openai_response.pygit diff --check origin/main...HEADReal-audio comparison using the issue attachment:
The CER comparison removes the unmatched 0-17.69 second teaser that is absent from the reference transcript and converts both reference and hypothesis to Simplified Chinese before retaining letters and numbers. The recovered passage is present after the change, although proper-name recognition such as
Blackwellremains imperfect.Related to #3419.