Skip to content

esm: fix loading of (recursive) CJS modules from ESM - #49500

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:fix-cjs-recursive
Sep 6, 2023
Merged

esm: fix loading of (recursive) CJS modules from ESM#49500
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:fix-cjs-recursive

Conversation

@aduh95

@aduh95 aduh95 commented Sep 5, 2023

Copy link
Copy Markdown
Contributor

Fixes: #49497

@nodejs-github-bot

nodejs-github-bot commented Sep 5, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Sep 5, 2023
@lilnasy lilnasy mentioned this pull request Sep 5, 2023
Closed
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 5, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 5, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53745/

nicolo-ribaudo
nicolo-ribaudo reviewed Sep 5, 2023
View reviewed changes
Comment thread test/fixtures/recursive-a.cjs
GeoffreyBooth
GeoffreyBooth reviewed Sep 5, 2023
View reviewed changes
Comment thread lib/internal/modules/esm/translators.js
@github-actions github-actions Bot mentioned this pull request Sep 6, 2023
Open
25 tasks
@nodejs-github-bot

nodejs-github-bot commented Sep 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53760/

@aduh95 aduh95 added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 6, 2023
@github-actions

github-actions Bot commented Sep 6, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@JakobJingleheimer

JakobJingleheimer commented Sep 6, 2023

Copy link
Copy Markdown
Member

Approving fast-track per:

node/doc/contributing/collaborator-guide.md

Line 186 in d8eb8d0

* Regressions that happen right before a release, or reported soon after.

introduced in 20.6.0 released yesterday

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. dont-land-on-v18.x labels Sep 6, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 6, 2023
@nodejs-github-bot
nodejs-github-bot merged commit fdc65d9 into nodejs:main Sep 6, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 6, 2023

Copy link
Copy Markdown
Collaborator

Landed in fdc65d9

@aduh95
aduh95 deleted the fix-cjs-recursive branch September 6, 2023 10:12
@camcamd camcamd mentioned this pull request Sep 6, 2023
Closed
@GeoffreyBooth GeoffreyBooth mentioned this pull request Sep 6, 2023
Merged
@github-actions github-actions Bot mentioned this pull request Sep 7, 2023
Open
20 tasks
This was referenced Sep 7, 2023
Merged
Merged
@azu azu mentioned this pull request Sep 7, 2023
Merged
@dustinnewman dustinnewman mentioned this pull request Sep 7, 2023
Closed
1 task
@nicolo-ribaudo

nicolo-ribaudo commented Sep 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hey, is there any indication for when we could expect this PR to be released? Multiple major projects are waiting for this regression fix: Babel, Angular, Astro, Nuxt, Vite

@w3nl

w3nl commented Sep 7, 2023

Copy link
Copy Markdown

This is the release schedule (expectation dates)
nodejs/Release#855

@nicolo-ribaudo

nicolo-ribaudo commented Sep 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you! It looks like there are only planned dates for the next minor versions there.

@UlisesGascon I see that you released 20.6.0 and are working on 20.7.0, maybe you can help here? :)

@RafaelGSS

RafaelGSS commented Sep 7, 2023

Copy link
Copy Markdown
Member

I'll create the v20.6.1 proposal. But, I won't be able to sign and promote (I'm travelling) - ping @nodejs/releasers.

RafaelGSS pushed a commit that referenced this pull request Sep 7, 2023
@aduh95 @RafaelGSS
esm: fix loading of CJS modules from ESM
8acbe6d 
PR-URL: #49500
Fixes: #49497
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
@RafaelGSS RafaelGSS mentioned this pull request Sep 7, 2023
Merged
@RafaelGSS

RafaelGSS commented Sep 7, 2023

Copy link
Copy Markdown
Member

#49528

@UlisesGascon

UlisesGascon commented Sep 7, 2023

Copy link
Copy Markdown
Member

I have bandwidth for it @RafaelGSS @nicolo-ribaudo, I can promote it but I will need first to unblock nodejs/Release#892 🙂

RafaelGSS added a commit that referenced this pull request Sep 7, 2023
@RafaelGSS
2023-09-08, Version 20.6.1 (Current)
d2c7c36 
Notable changes:

esm:
  * fix loading of CJS modules from ESM (Antoine du Hamel) #49500

PR-URL: #49528
@github-actions github-actions Bot mentioned this pull request Sep 8, 2023
Open
26 tasks
@webpro webpro mentioned this pull request Sep 8, 2023
Closed
ruyadorno pushed a commit that referenced this pull request Sep 8, 2023
@RafaelGSS @ruyadorno
2023-09-08, Version 20.6.1 (Current)
0a2ab4c 
Notable changes:

esm:
  * fix loading of CJS modules from ESM (Antoine du Hamel) #49500

PR-URL: #49528
@github-actions github-actions Bot mentioned this pull request Sep 9, 2023
Open
24 tasks
@egeres egeres mentioned this pull request Sep 12, 2023
Closed
1 task
@shamoon shamoon mentioned this pull request Sep 14, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qard Qard Qard approved these changes
@GeoffreyBooth GeoffreyBooth GeoffreyBooth left review comments
@benjamingr benjamingr benjamingr approved these changes
@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes
+2 more reviewers
@Jason3S Jason3S Jason3S left review comments
@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[v20.6] CJS runs repeatedly when there are circular dependencies when loaded by ESM