[v18.x] http: remove closeIdleConnections function while calling server close. - #52336
[v18.x] http: remove closeIdleConnections function while calling server close.#52336kumarrishav wants to merge 2 commits into
Conversation
|
Review requested:
|
nodejs-github-bot
added
http
kumarrishav
changed the title
Correcting the nodejs#50194 backporting mistake. closeIdleConnections shouldnot be called while server.close in node v18. This behavior is for node v19 and above. fixes: nodejs#52330, nodejs#51677
|
the timeout tests should not be deleted, as they check the interval change which is still kept. |
|
Correct. I doubted that too. I misunderstood the previous message regarding deleting test. @Linkgoron |
|
@Linkgoron should i be raising the PR against v18.x or v18.x-staging branch? CC: @richardlau |
v18.x-staging. |
|
Done |
github-actions
Bot
removed
the
request-ci
|
can we go ahead with review and merge? |
|
can we target this for v18.20.3 release? |
|
Will there be separate PR for v19/20/21 ? or does this propagate to newer versions? |
No. This new behavior is expected in v19 and above. https://nodejs.org/docs/latest-v19.x/api/http.html#serverclosecallback This PR is only for v18 where this is not expected and was a backporting mistake. https://nodejs.org/docs/latest-v18.x/api/http.html#serverclosecallback |
|
@richardlau can we get this merge and land on v18? |
|
Landed in 6689a98. |
Four quick-adds the S1 review flagged for S2 to bring along: - close(): explicit closeIdleConnections()/closeAllConnections() fallback, typeof-guarded for Node 18.0-18.18 (the methods land in 18.2.0, nodejs/node#42812) — Node's own close() briefly auto-invoked closeIdleConnections internally on some 18.x releases via a mistaken v19-only backport, reverted in 18.20.3 (nodejs/node#52336), so close() alone can't be assumed sufficient on any given patch. - Extend the ENOENT watch-setup comment: a pages/or assets/ directory created after startup is never picked up until pptfast serve restarts. - Two watch tests: a file appearing in assets/ triggers a rebuild, and a deck.spec.json-only edit (no pages/ touch) triggers one too — S1's own coverage only exercised pages/*.json. - One-line comment at runPreview's moved mkdir(outDir) noting the deliberate after-render timing.
5 participants
Correcting the #50194 backporting mistake.
closeIdleConnections shouldnot be called while server.close in node v18. This behavior is for node v19 and above.
fixes: #52330, #51677