Skip to content

deps: patch V8 to 12.8.374.22 - #54435

Closed
nodejs-github-bot wants to merge 0 commit into
mainfrom
actions/update-v8-patch
Closed

deps: patch V8 to 12.8.374.22#54435
nodejs-github-bot wants to merge 0 commit into
mainfrom
actions/update-v8-patch

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented Aug 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This is an automated patch update of V8 to 12.8.374.22.

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Aug 18, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 18, 2024

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 18, 2024
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 18, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 18, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/61193/

@nodejs-github-bot

nodejs-github-bot commented Aug 18, 2024

Copy link
Copy Markdown
Collaborator Author

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6140/

@nodejs-github-bot

nodejs-github-bot commented Aug 18, 2024

Copy link
Copy Markdown
Collaborator Author

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6140/

@nodejs-github-bot

nodejs-github-bot commented Aug 18, 2024

Copy link
Copy Markdown
Collaborator Author

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6140/

@nodejs-github-bot

nodejs-github-bot commented Aug 24, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/61409/

@nodejs-github-bot nodejs-github-bot changed the title deps: patch V8 to 12.8.374.16 deps: patch V8 to 12.8.374.22 Aug 25, 2024
@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Aug 25, 2024
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2024
@nodejs-github-bot

nodejs-github-bot commented Aug 26, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/61470/

@nodejs-github-bot

nodejs-github-bot commented Aug 26, 2024

Copy link
Copy Markdown
Collaborator Author

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6153/

@nodejs-github-bot

nodejs-github-bot commented Aug 26, 2024

Copy link
Copy Markdown
Collaborator Author

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6153/

@nodejs-github-bot

nodejs-github-bot commented Aug 26, 2024

Copy link
Copy Markdown
Collaborator Author

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6153/

@nodejs-github-bot

nodejs-github-bot commented Aug 27, 2024

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/61561/

@nodejs-github-bot
nodejs-github-bot deleted the actions/update-v8-patch branch September 1, 2024 00:36
@targos

targos commented Sep 1, 2024

Copy link
Copy Markdown
Member

This was closed because the update script failed with a zero exit code: https://github.com/nodejs/node/actions/runs/10649452944/job/29519654967

Run ./tools/dep_updaters/update-v8-patch.sh > temp-output
Error: spawn git ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:286:1[9](https://github.com/nodejs/node/actions/runs/10649452944/job/29519654967#step:7:10))
    at onErrorNT (node:internal/child_process:484:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn git',
  path: 'git',
  spawnargs: [ 'fetch', 'origin' ]
}
✖ Do minor update to [12](https://github.com/nodejs/node/actions/runs/10649452944/job/29519654967#step:7:13).8.374.26 [FAILED: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of ChildProcess]
✖ Minor V8 update [FAILED: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of ChildProcess]
✖ The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received an instance of ChildProcess
All done!

@targos

targos commented Sep 1, 2024

Copy link
Copy Markdown
Member

I opened nodejs/node-core-utils#850

@targos
targos restored the actions/update-v8-patch branch September 1, 2024 07:32
targos pushed a commit to targos/node that referenced this pull request Sep 1, 2024
@nodejs-github-bot @targos
deps: patch V8 to 12.8.374.22
0c771c3 
Refs: v8/v8@12.8.374.13...12.8.374.22

PR-URL: nodejs#54435
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@targos

targos commented Sep 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Landed in 0c771c3 (CI was green before the workflow deleted the branch).

@aduh95

aduh95 commented Sep 12, 2024

Copy link
Copy Markdown
Contributor

Should this be marked as dont-land?

@targos

targos commented Sep 12, 2024

Copy link
Copy Markdown
Member

Yes, on all release lines

@aduh95 aduh95 added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Sep 12, 2024
@aduh95 aduh95 mentioned this pull request Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@nodejs-github-bot @targos @aduh95 @jasnell @lpinca @gengjiawen @RafaelGSS @marco-ippolito