Skip to content

nodejs-ca: Add Catalan language - #1221

Merged
fhemberger merged 5 commits into
nodejs:masterfrom
franher:add-locale-ca
May 25, 2017
Merged

nodejs-ca: Add Catalan language#1221
fhemberger merged 5 commits into
nodejs:masterfrom
franher:add-locale-ca

Conversation

@franher

@franher franher commented May 11, 2017

Copy link
Copy Markdown
Contributor

This PR is related to #1197

I created the minimal set of files according Node.js Website Translation Policy indications.

  • nodejs-ca: Add files - index.md, 404.md, security.md, site.json

@franher franher mentioned this pull request May 11, 2017
@gtewallace

Copy link
Copy Markdown
Contributor

Molt be!!

@fhemberger

Copy link
Copy Markdown
Contributor

Can anyone please check the translation and give a +1?

@sotayamashita

sotayamashita commented May 22, 2017

Copy link
Copy Markdown
Contributor

Please review it, if you can. 🙇 - @jseijas, @yagoff

@franher

franher commented May 23, 2017

Copy link
Copy Markdown
Contributor Author

Hello @sotayamashita, @jseijas and @yagoff are not catalan speakers, so I think they cannot validate my translations.

@axarrafols is doing the review. I'm gonna fix a couple of typo and I tell him for the final validation.

@PatrickHeneise

Copy link
Copy Markdown
Contributor

Maybe @sgimeno or @masylum can validate?

Comment thread locale/ca/index.md Outdated
---

Node.js® és un entorn d'execució per a JavaScript construït amb el [motor de JavaScript V8 de Chrome](https://developers.google.com/v8/).
Node.js fa servir un model d'operacions E/S sense bloqueig i orientat a esdeveniments, que el fa lleuger i eficient.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny improvement ... i orientat a esdeveniments, (motiu pel qual | cosa que el fa)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me know if you have found something more and then I'll do the final commit 💪 thanks dude @sgimeno !

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some "super-tiny" improvements, they might even be wrong... All reads good to me, good job 👍

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @sgimeno I just committed changes according your indications 6b1a8b2

If everything looks ok for you, could you give me 👍 ?

Comment thread locale/ca/security.md Outdated

- A la data d'embargament, se li envia una còpia de l'anunci a la llista de correu de seguretat de Node.js. Els canvis són pujats al repositori públic i noves versions són desplegades en nodejs.org. En les següents 6 hores de la notificació a la llista de correu, una còpia de l'anunci es publicarà al blog de Node.js.

- Normalment la data d'embargament s'establirà 72 hores des de la creació del CVE. Però, això pot variar depenent de

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need a pause after the conjunction I think: Però (,)

Comment thread locale/ca/site.json Outdated
"blog": { "link": "blog", "text": "Notícies" },

"releases": {
"title": "Release History",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be this translated to catalan?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure I missed that 😭

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andresgutgon added missed translation on a2afa18

@sotayamashita

sotayamashita commented May 23, 2017

Copy link
Copy Markdown
Contributor

@franher Oops, sorry. By the way, is there nodejs-ca team. I cannot find that ?

@franher

franher commented May 24, 2017

Copy link
Copy Markdown
Contributor Author

@sotayamashita no problem :)

As soon I know, there is not Node.js Catalan team.

@sgimeno

sgimeno commented May 24, 2017

Copy link
Copy Markdown

What's the purpose of these teams?

@franher

franher commented May 25, 2017

Copy link
Copy Markdown
Contributor Author

@fhemberger hello :) I think some catalan colleagues have already done the review and have given +1

@fhemberger
fhemberger merged commit 75ba429 into nodejs:master May 25, 2017
@fhemberger

Copy link
Copy Markdown
Contributor

Cool, thanks for your contribution!

@franher
franher deleted the add-locale-ca branch May 25, 2017 15:53
@sotayamashita

Copy link
Copy Markdown
Contributor

@sgimeno I think local teams are responsible for management local translation. When someone translates docs into the Catalan language, we need to review but if the team does not exist, it could be very hard to find people can review. Does it make sense?

@sgimeno

sgimeno commented May 29, 2017

Copy link
Copy Markdown

@sotayamashita sure. Does it make sense to build that team now for future reviews and contributions? I'm up for it

@franher

franher commented May 29, 2017

Copy link
Copy Markdown
Contributor Author

@sgimeno I'm available too :)

@albertvp

Copy link
Copy Markdown

@sgimeno @franher count on me!

Comment thread locale/ca/site.json
"scrollToTop": "Torna al començament",
"reportNodeIssue": "Informe d'un problema de Node.js",
"reportWebsiteIssue": "Informe d'un problema al lloc web",
"getHelpIssue": "Aconseguir ajuda",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"scrollToTop": "Tornar al començament",
"reportNodeIssue": "Informi d'un problema de Node.js",
"reportWebsiteIssue": "Informi d'un problema al lloc web",
"getHelpIssue": "Ajuda",

This sounds better to me... @franher

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great @albertvp the PR is already landed in, so I invite you to create new one adding this modifications and more translations (the remaining files)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll check them in detail

@albertvp

Copy link
Copy Markdown

The links on navigation menu are broken... maybe there's any missed file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants