Skip to content

[BUG] Broken usage message for approve-scripts - --all option collision #9448

Description

@naugtur

Is there an existing issue for this?

  • I have searched the existing issues

This issue exists in the latest npm version

  • I am using the latest npm

Current Behavior

description for --all clashes with the same option name from elsewhere.

$ npm approve-scripts --help
Approve install scripts for specific dependencies

Usage:
npm approve-scripts <pkg> [<pkg> ...]
npm approve-scripts --all
npm approve-scripts --allow-scripts-pending

Options:
[-a|--all] [--allow-scripts-pending] [--no-allow-scripts-pin] [--json]

  -a|--all
    When running `npm outdated` and `npm ls`, setting `--all` will show

  --allow-scripts-pending
    List packages with install scripts that are not yet covered by the

  --allow-scripts-pin
    Write pinned (`pkg@version`) entries when approving install scripts.

  --json
    Whether or not to output JSON data, rather than the normal output.


Run "npm help approve-scripts" for more info
$ npm approve-scripts 
npm error code EUSAGE
npm error
npm error Approve install scripts for specific dependencies
npm error
npm error Usage:
npm error npm approve-scripts <pkg> [<pkg> ...]
npm error npm approve-scripts --all
npm error npm approve-scripts --allow-scripts-pending
npm error
npm error Options:
npm error [-a|--all] [--allow-scripts-pending] [--no-allow-scripts-pin] [--json]
npm error
npm error   -a|--all
npm error     When running `npm outdated` and `npm ls`, setting `--all` will show
npm error
npm error   --allow-scripts-pending
npm error     List packages with install scripts that are not yet covered by the
npm error
npm error   --allow-scripts-pin
npm error     Write pinned (`pkg@version`) entries when approving install scripts.
npm error
npm error   --json
npm error     Whether or not to output JSON data, rather than the normal output.
npm error
npm error
npm error Run "npm help approve-scripts" for more info

Expected Behavior

correct message printed

Steps To Reproduce

npm approve-scripts --help

Environment

npm -v
11.16.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    Bugthing that needs fixingNeeds Triageneeds review for next steps

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions