fix(deps): pin vite to 8.0.x (< 8.1) to unbreak DevTools e2e - #1020
Merged
Conversation
Vite 8.1 changed WebSocket-upgrade handling, and @vitejs/devtools@0.4's route-bound RPC socket (crossws, attached to Vite's HTTP server) ends up calling server.handleUpgrade() twice on the same socket under SSR, killing the DevTools socket so __VITE_DEVTOOLS_CLIENT_CONTEXT__ never initializes and the client injection never lands. That turns every SSR playground e2e red (empty / tab-pinia / tab-seo), while the ssr:false spa playground dodges the second environment's handler and stays green. @vitejs/devtools has no Vite 8.1-compatible release yet (still 0.4.0, peer vite: *), so pin the vite override to ~8.0.14 (resolves 8.0.16). Unpin once @vitejs/devtools ships Vite 8.1 support.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Deploying nuxt-devtools with
|
| Latest commit: |
fad5212
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://90875509.nuxt-devtools.pages.dev |
| Branch Preview URL: | https://fix-pin-vite-8-0-e2e.nuxt-devtools.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
maine2e is red: Vite is currently pinned to^8.1.4in theoverridesblock ofpnpm-workspace.yaml.Vite 8.1 changed WebSocket-upgrade handling, and
@vitejs/devtools@0.4's route-bound RPC socket (crossws, attached to Vite's HTTP server) ends up callingserver.handleUpgrade()twice on the same socket under SSR:That kills the DevTools socket, so
__VITE_DEVTOOLS_CLIENT_CONTEXT__never initializes and the client injection never lands — every SSR playground e2e times out (empty / tab-pinia / tab-seo), while thessr: falsespa playground dodges the second environment's upgrade handler and stays green.(A prior fix for this landed in #1012, but it went stale/conflicting after #1015 rewrote the
overridesblock to use literal ranges instead ofcatalog:refs. This PR reapplies the same fix rebased onto currentmain.)Fix
@vitejs/devtoolshas no Vite 8.1-compatible release yet (still0.4.0, peervite: *), so pin theviteoverride to~8.0.14(resolves 8.0.16). Unpin once@vitejs/devtoolsships Vite 8.1 support.Verification
pnpm test:e2e:dev: 44 passed / 12 skipped, 0 failurespnpm test:e2e:built: 3 passed / 53 skipped, 0 failurespnpm lint,pnpm build,pnpm typecheck,pnpm test:unitall passThis PR was created with the help of an agent.