jQuery -> $ in src/metisMenu.js to fix import. - #158
Merged
Conversation
Contributor
Author
|
Update: my previous built would've been broken in browser environment. It required addition of babel-plugin-transform-es2015-modules-umd to fix renaming of I didn't run an extensive testing so far though. UPDATE: tested in browser with Webpack build - works fine now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First line of import.js imports
jQueryas$. Accordingly, under$name it should be visible to the rest of the module.Thus, I replaced global
jQueryinMetisMenuandUtilwith$in constructor invocations and now metismenu will be successfully executed in node.js environment.