Adapt test_dataset_math_errors for coming NumPy behavior change - #11435
Merged
Conversation
spencerkclark
changed the title
test_dataset_math_errors for coming NumPy changestest_dataset_math_errors for coming NumPy behavior change
dcherian
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adapts
test_dataset_math_errorsfor coming updates in NumPy. We can no longer rely on arithmetic betweendatetime64values and plain integers working without a warning or error.My understanding of this test is that we want adding a
datetime64value to"bar"to succeed so that we can check that the failure in adding adatetime64value to"foo"prevents updating any variable in the Dataset. Therefore we explicitly cast"bar"to an array of"timedelta64[ns]"values so that this continues to be the case moving forward.Even though it is not strictly necessary, we also provide units in the
datetime64constructor when creatingother.Addresses one part of #11402.