Skip to content

Update chat actions - #2460

Merged
Bibo-Joshi merged 4 commits into
masterfrom
update-chat-actions
Apr 22, 2021
Merged

Update chat actions#2460
Bibo-Joshi merged 4 commits into
masterfrom
update-chat-actions

Conversation

@Bibo-Joshi

Copy link
Copy Markdown
Member

Found out by accident that chatAction.upload/record_audio has been replaced by voice somewhere between 11/2020 and 12/2020. Kudos @RenshouSorinozuka for making me find this :D

the audio-things still work because of this: https://github.com/tdlib/telegram-bot-api/blob/bf371b21b97c4c8d0b2e2646db05c654cb05480e/telegram-bot-api/Client.cpp#L4850 but backward compatibility is undocumented. I pinged botsupport asking them to at least document the change/announce somewhere, so I'd wait with mergen a bit to give them a change to update the docs, which we then could properly copy.

Also I didn't find a good way to add a deprecation warning to constants … Maybe someone has an idea? Then again, maybe it's not necessary.

Checklist for PRs

  • Added .. versionadded:: version, .. versionchanged:: version or .. deprecated:: version to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Added myself alphabetically to AUTHORS.rst (optional)

If the PR contains API changes (otherwise, you can delete this passage)

  • If relevant:

    • Added new constants at telegram.constants and shortcuts to them as class variables
    • Added new handlers for new update types
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Updated the Bot API version number in all places: README.rst and README_RAW.rst (including the badge), as well as telegram.constants.BOT_API_VERSION

@Bibo-Joshi Bibo-Joshi added the ⚙️ bot-api affected functionality: bot-api label Apr 11, 2021
@Bibo-Joshi Bibo-Joshi added this to the v13.5 milestone Apr 11, 2021

@starry-shivam starry-shivam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@harshil21 harshil21 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's not necessary.

Don't think it's needed for now.

Comment thread tests/test_bot.py Outdated
@Bibo-Joshi

Copy link
Copy Markdown
Member Author

Reply from botsupport:

That was always an alias to upload_voice, never was a separate thing and, therefore, didn't have any effect. Hence was simplified in the docs.

Merging.

@Bibo-Joshi
Bibo-Joshi merged commit 3b92901 into master Apr 22, 2021
@Bibo-Joshi
Bibo-Joshi deleted the update-chat-actions branch April 22, 2021 06:57
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

⚙️ bot-api affected functionality: bot-api

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants