Improved Message.link - #3640
Merged
Merged
Conversation
Contributor
Author
|
In the end I just added two lines to detect if the message is a topic message, in which case append the I think that's all that is needed because it reflects what official clients do. |
Trifase
marked this pull request as ready for review
March 30, 2023 21:59
Bibo-Joshi
requested changes
Apr 2, 2023
Bibo-Joshi
left a comment
Bibo-Joshi
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR! The changes themself look good - I guess you double checked that this is working on at least the official clients? However I'm missing
- a
versionchanged::telling the user that the property now also reflects the reply-thingy - support for
reply_to_message_idin non-topic groups
Could you add those as well?
lemontree210
reviewed
Apr 3, 2023
Co-authored-by: Dmitry Kolomatskiy <58207913+lemontree210@users.noreply.github.com>
Bibo-Joshi
requested changes
Apr 5, 2023
Co-authored-by: Bibo-Joshi <22366557+Bibo-Joshi@users.noreply.github.com>
Bibo-Joshi
approved these changes
Apr 7, 2023
Bibo-Joshi
left a comment
Bibo-Joshi
left a comment
Member
There was a problem hiding this comment.
Thanks for the Updates! LGTM now :) @Poolitzer do you have any comments left?
Member
|
nope Im good feel free to merge |
Member
|
Thank you for the contribution @Trifase 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When done will close #3475
Checklist for PRs
.. versionadded:: version,.. versionchanged:: versionor.. deprecated:: versionto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)