[3.10] bpo-45584: Clarify math.trunc documentation (GH-29183) - #32273
Merged
Conversation
While floor/ceil 's documentation are very precise, `truncate` was not explained. I actually had to search online to understand the difference between `truncate` and `floor` (admittedly, once I remembered that numbers are signed, and that floating numbers actually uses a bit for negation symbol instead of two complement, it became obvious) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com> Co-authored-by: Éric Araujo <merwok@netwok.org> Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit ebbdbbf) Co-authored-by: Arthur Milchior <arthur@milchior.fr>
JelleZijlstra
approved these changes
Apr 2, 2022
Contributor
Author
|
@Arthur-Milchior and @JelleZijlstra: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@Arthur-Milchior and @JelleZijlstra: Status check is done, and it's a failure ❌ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While floor/ceil 's documentation are very precise,
truncatewas not explained. I actually had to search online to understand the difference betweentruncateandfloor(admittedly, once I remembered that numbers are signed, and that floating numbers actually uses a bit for negation symbol instead of two complement, it became obvious)Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com
Co-authored-by: Éric Araujo merwok@netwok.org
Co-authored-by: Terry Jan Reedy tjreedy@udel.edu
Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com
(cherry picked from commit ebbdbbf)
Co-authored-by: Arthur Milchior arthur@milchior.fr
https://bugs.python.org/issue45584