Skip to content

Fix compilation on more platforms - #4713

Merged
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:fix-bsd
Nov 12, 2017
Merged

Fix compilation on more platforms#4713
bors merged 1 commit into
rust-lang:masterfrom
alexcrichton:fix-bsd

Conversation

@alexcrichton

Copy link
Copy Markdown
Member

No description provided.

@rust-highfive

Copy link
Copy Markdown

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

@matklad

matklad commented Nov 12, 2017

Copy link
Copy Markdown
Contributor

bors r+

@matklad

matklad commented Nov 12, 2017

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Nov 12, 2017

Copy link
Copy Markdown
Contributor

📌 Commit 51e5899 has been approved by matklad

@kennytm

kennytm commented Nov 12, 2017

Copy link
Copy Markdown
Member

The BSDs do have TIOCGWINSZ. The constants are just defined as c_int on some platforms and c_ulong on others. The error on rust-lang/rust#45692 is actually about rust-lang/libc#704.

@alexcrichton

Copy link
Copy Markdown
Member Author

@kennytm yeah I just didn't want to deal with all the portability stuff here, for me it was easier to just ignore on other platforms as it's a new feature anyway.

bors added a commit that referenced this pull request Nov 12, 2017
Fix compilation on more platforms
@bors

bors commented Nov 12, 2017

Copy link
Copy Markdown
Contributor

⌛ Testing commit 51e5899 with merge e945a90...

@bors

bors commented Nov 12, 2017

Copy link
Copy Markdown
Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: matklad
Pushing e945a90 to master...

@bors
bors merged commit 51e5899 into rust-lang:master Nov 12, 2017
@alexcrichton
alexcrichton deleted the fix-bsd branch December 18, 2017 19:47
@ehuss ehuss added this to the 1.23.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants