Skip to content

Fix regression when passing arguments to subcommands - #5209

Merged
bors merged 1 commit into
rust-lang:masterfrom
matklad:no-way-we-havent-had-a-test-for-this
Mar 20, 2018
Merged

Fix regression when passing arguments to subcommands#5209
bors merged 1 commit into
rust-lang:masterfrom
matklad:no-way-we-havent-had-a-test-for-this

Conversation

@matklad

@matklad matklad commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

closes #5208

.args(&args[1..]) was copied directly from the docopt implementation, but there, args[0] was the path to cargo and not the name of subcommand, ie, args were original arguments for Cargo as a whole.

@rust-highfive

Copy link
Copy Markdown

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@bors

bors commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

@rust-highfive: 🔑 Insufficient privileges: Not in reviewers

@bors

bors commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

@rust-highfive: 🔑 Insufficient privileges: not in try users

@alexcrichton

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

📌 Commit 84e08c2 has been approved by alexcrichton

@matklad

matklad commented Mar 19, 2018

Copy link
Copy Markdown
Contributor Author

War of robots against robots?

@matklad

matklad commented Mar 19, 2018

Copy link
Copy Markdown
Contributor Author

@bors: p=1

@bors

bors commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

🔒 Merge conflict

@bors

bors commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #5207) made this pull request unmergeable. Please resolve the merge conflicts.

@matklad
matklad force-pushed the no-way-we-havent-had-a-test-for-this branch from 84e08c2 to 0928135 Compare March 19, 2018 22:28
@matklad

matklad commented Mar 19, 2018

Copy link
Copy Markdown
Contributor Author

@bors: r=alexcrichton

@bors

bors commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

📌 Commit 0928135 has been approved by alexcrichton

@bors

bors commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

⌛ Testing commit 0928135588a4d8fb9f92d023459ce44f2b0f2e01 with merge 175bca5d7a090e9adaa368fd04ecf85368fa147c...

@bors

bors commented Mar 20, 2018

Copy link
Copy Markdown
Contributor

💔 Test failed - status-appveyor

@matklad
matklad force-pushed the no-way-we-havent-had-a-test-for-this branch from 0928135 to 984c22e Compare March 20, 2018 00:21
@matklad
matklad force-pushed the no-way-we-havent-had-a-test-for-this branch from 984c22e to deb1c1e Compare March 20, 2018 00:35
@matklad

matklad commented Mar 20, 2018

Copy link
Copy Markdown
Contributor Author

@bors: r=alexcrichton

@bors

bors commented Mar 20, 2018

Copy link
Copy Markdown
Contributor

📌 Commit deb1c1e has been approved by alexcrichton

@bors

bors commented Mar 20, 2018

Copy link
Copy Markdown
Contributor

⌛ Testing commit deb1c1e with merge d10ec66...

bors added a commit that referenced this pull request Mar 20, 2018
…=alexcrichton

Fix regression when passing arguments to subcommands

closes #5208

`.args(&args[1..])` was copied directly from the docopt implementation, but there, `args[0]` was the path to `cargo` and not the name of subcommand, ie, `args` were *original* arguments for Cargo as a whole.
@bors

bors commented Mar 20, 2018

Copy link
Copy Markdown
Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing d10ec66 to master...

@bors
bors merged commit deb1c1e into rust-lang:master Mar 20, 2018
@matklad
matklad deleted the no-way-we-havent-had-a-test-for-this branch March 20, 2018 07:48
@ehuss ehuss added this to the 1.26.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nightly 2018/03/19: change of position of arguments passed to cargo subcommands

5 participants