Conversation
flip1995
reviewed
Apr 7, 2019
|
|
||
| #[warn(clippy::identity_conversion)] | ||
| fn run_ui_toml_tests(config: &compiletest::Config, mut tests: Vec<TestDescAndFn>) -> Result<bool, io::Error> { | ||
| #[allow(clippy::identity_conversion)] |
Member
There was a problem hiding this comment.
This line should be removed completely (sometime). It's a bug that this lint started to trigger and therefore we set it to warn instead of deny for the dogfood test. #3913
If this bug still exists (which I think is the case) this line should stay unchanged.
Member
Author
There was a problem hiding this comment.
Remember, compile-test.rs is a different crate, so allow()s applied elsewhere will not help here.
Member
Author
|
Hmm, appveyor fails (but not travis) on rustc_term issues... |
Member
Author
|
Ah we still depend on libtest |
Member
Author
|
@bors r+ |
Contributor
|
📌 Commit 4c7c39a has been approved by |
bors
added a commit
that referenced
this pull request
Apr 7, 2019
Revert compiletest hacks, use latest compiletest The libtest changes have been reverted, see rust-lang/rust#59766, Manishearth/compiletest-rs#174
Contributor
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libtest changes have been reverted, see rust-lang/rust#59766, Manishearth/compiletest-rs#174