Clean up the checks for `Self` type parameters

[cuviper]

per @eddyb in #49889 (comment)

I don't think we should need is_self and has_self_ty (or the gensym hack altogether), and instead we should rely on knowing that e.g. the item in scope is a trait and thus index 0 is Self.