Avoid unbounded O(n^2) when parsing nested type args - #117143
Merged
Merged
Conversation
Collaborator
|
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Contributor
Author
|
@bors try |
Collaborator
This comment has been minimized.
This comment has been minimized.
estebank
force-pushed
the
issue-117080
branch
from
October 24, 2023 22:33
54dffa1 to
7bce646
Compare
Member
|
Might also fix #115414 perhaps? ^^ |
Contributor
Author
|
@matthiaskrgr it does! 😀 |
estebank
added
the
beta-nominated
mcol
reviewed
Oct 25, 2023
When encountering code like `f::<f::<f::<f::<f::<f::<f::<f::<...` with unmatched closing angle brackets, add a linear check that avoids the exponential behavior of the parse recovery mechanism. Fix rust-lang#117080.
estebank
force-pushed
the
issue-117080
branch
from
October 25, 2023 19:07
7bce646 to
2dec1bc
Compare
wesleywiser
approved these changes
Oct 26, 2023
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
Contributor
rustbot
removed
the
beta-nominated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When encountering code like
f::<f::<f::<f::<f::<f::<f::<f::<...with unmatched closing angle brackets, add a linear check that avoids the exponential behavior of the parse recovery mechanism.Fix #117080, fix #115414.