Skip to content

Do not attempt to write ty::Err on binding that isn't from current HIR Owner - #123202

Merged
bors merged 1 commit into
rust-lang:masterfrom
estebank:issue-123009
Mar 30, 2024
Merged

Do not attempt to write ty::Err on binding that isn't from current HIR Owner#123202
bors merged 1 commit into
rust-lang:masterfrom
estebank:issue-123009

Conversation

@estebank

Copy link
Copy Markdown
Contributor

Fix #123009. Follow up to #122119.

@rustbot

rustbot commented Mar 29, 2024

Copy link
Copy Markdown
Collaborator

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 29, 2024
@compiler-errors

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Mar 29, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit d54e983 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2024
@bors

bors commented Mar 30, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d54e983 with merge 7e0ed43...

@bors

bors commented Mar 30, 2024

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 7e0ed43 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 30, 2024
@bors
bors merged commit 7e0ed43 into rust-lang:master Mar 30, 2024
@rustbot rustbot added this to the 1.79.0 milestone Mar 30, 2024
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (7e0ed43): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 669.053s -> 669.392s (0.05%)
Artifact size: 315.73 MiB -> 315.78 MiB (0.01%)

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 31, 2024
Stop calling visitors `V`

Renames some visitors which currently have the unhelpful name of `V`. It's not self-documenting, and there is no situation where saving a few bytes in source code helps anyone.

Stacked on top of rust-lang#123202 due to conflict.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 31, 2024
Rollup merge of rust-lang#123211 - compiler-errors:V, r=estebank

Stop calling visitors `V`

Renames some visitors which currently have the unhelpful name of `V`. It's not self-documenting, and there is no situation where saving a few bytes in source code helps anyone.

Stacked on top of rust-lang#123202 due to conflict.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE: node HirId cannot be placed in TypeckResults with hir_owner DefId

6 participants