pattern analysis: Require enum indices to be contiguous - #123242
Merged
Conversation
rustbot
added
S-waiting-on-review
compiler-errors
approved these changes
Mar 31, 2024
Contributor
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
Member
Author
|
Ty! @bors rollup |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 31, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#123189 (Log BOLT args in bootstrap `rustc` shim) - rust-lang#123211 (Stop calling visitors `V`) - rust-lang#123242 (pattern analysis: Require enum indices to be contiguous) - rust-lang#123260 (Miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 31, 2024
Rollup merge of rust-lang#123242 - Nadrieril:require-contiguous-enum-indices, r=compiler-errors pattern analysis: Require enum indices to be contiguous We had a cfg-hack to allow rust-analyzer to use non-contiguous indices for its enum variants. Unfortunately this no longer works if r-a uses the in-tree version of the crate. This PR removes the hack, and on the r-a side we'll have to use contiguous indices but that's not too hard. r? `@compiler-errors`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a cfg-hack to allow rust-analyzer to use non-contiguous indices for its enum variants. Unfortunately this no longer works if r-a uses the in-tree version of the crate.
This PR removes the hack, and on the r-a side we'll have to use contiguous indices but that's not too hard.
r? @compiler-errors