Mention more APIs in ParseIntError docs - #143611
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
lolbinarycat
reviewed
Jul 7, 2025
lolbinarycat
left a comment
lolbinarycat
left a comment
Contributor
There was a problem hiding this comment.
Looks mostly good to me, but I don't have reviewer permissions, so..
r? t-libs
| /// | ||
| /// This error is used as the error type for the `from_str_radix()` functions | ||
| /// on the primitive integer types, such as [`i8::from_str_radix`]. | ||
| /// For example, this error is used in `from_str_radix()` functions |
Contributor
There was a problem hiding this comment.
Suggested change
| /// For example, this error is used in `from_str_radix()` functions | |
| /// For example, this error is returned by the `from_str_radix()` functions |
nit
Member
|
Just as a general note, you should not usually |
GrigorenkoPV
force-pushed
the
ParseIntError
branch
from
July 7, 2025 21:17
c8af02b to
ce88dd2
Compare
lolbinarycat
reviewed
Jul 7, 2025
| /// on the primitive integer types, such as [`i8::from_str_radix`]. | ||
| /// For example, this error is returned by the `from_str_radix()` functions | ||
| /// on the primitive integer types (such as [`i8::from_str_radix`]) | ||
| /// and as the error type in their [`FromStr`] implementations. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// and as the error type in their [`FromStr`] implementations. | |
| /// and is used as the error type in their [`FromStr`] implementations. |
Just realized my change to the first half means the second half also needs to be rewritten in order to still make sense.
GrigorenkoPV
force-pushed
the
ParseIntError
branch
from
July 7, 2025 22:05
ce88dd2 to
ae5cb5f
Compare
lolbinarycat
approved these changes
Jul 10, 2025
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #143602
r? @lolbinarycat
@rustbot label +A-docs