Skip to content

Stabilize feature isolate_most_least_significant_one - #155130

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
okaneco:stabilize_iso_high_one
Apr 12, 2026
Merged

Stabilize feature isolate_most_least_significant_one#155130
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
okaneco:stabilize_iso_high_one

Conversation

@okaneco

@okaneco okaneco commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

FCP completed #136909 (comment)

Closes #136909

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 10, 2026
@rustbot

rustbot commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, scottmcm

@rust-log-analyzer

This comment has been minimized.

@okaneco
okaneco force-pushed the stabilize_iso_high_one branch from b378309 to a69f989 Compare April 10, 2026 21:59
@tgross35

Copy link
Copy Markdown
Contributor

Cc @rust-lang/wg-const-eval, the const stabilization here is trivial but I think we usually ping you anyways.

@RalfJung

Copy link
Copy Markdown
Member

I think we can move to a model where when it's entirely a library implementation that a user could have already written and there are no intrinsics, no unstable lang features, and no rustc_allow_const_fn_unstable involved, then we don't have to be involved. (But that's just my opinion, we haven't discussed this as a WG yet.)

@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r+

https://std-dev-guide.rust-lang.org/development/stabilization.html#when-theres-const-involved indicate a ping is sufficient right now, updating that to exclude trivial cases would make sense to me too. Maybe someone wants to file a PR against the guide? :)

@rust-bors

rust-bors Bot commented Apr 11, 2026

Copy link
Copy Markdown
Contributor

📌 Commit a69f989 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2026
rust-bors Bot pushed a commit that referenced this pull request Apr 11, 2026
…uwer

Rollup of 6 pull requests

Successful merges:

 - #155057 (Update libc to v0.2.184)
 - #154967 (Test(lib/sync): Fix `test_rwlock_max_readers` for x86 Win7)
 - #154994 (don't leak internal temporaries from `dbg!`)
 - #155130 (Stabilize feature `isolate_most_least_significant_one`)
 - #154925 (Make Box/Rc/Arc::into_array allocator-aware (and add doctest))
 - #155063 (`ty::Alias`: replace `def_id: did` with `def_id`)
rust-bors Bot pushed a commit that referenced this pull request Apr 12, 2026
…uwer

Rollup of 6 pull requests

Successful merges:

 - #155057 (Update libc to v0.2.184)
 - #154967 (Test(lib/sync): Fix `test_rwlock_max_readers` for x86 Win7)
 - #154994 (don't leak internal temporaries from `dbg!`)
 - #155130 (Stabilize feature `isolate_most_least_significant_one`)
 - #154925 (Make Box/Rc/Arc::into_array allocator-aware (and add doctest))
 - #155063 (`ty::Alias`: replace `def_id: did` with `def_id`)
@rust-bors
rust-bors Bot merged commit 73a3824 into rust-lang:main Apr 12, 2026
11 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 12, 2026
rust-timer added a commit that referenced this pull request Apr 12, 2026
Rollup merge of #155130 - okaneco:stabilize_iso_high_one, r=Mark-Simulacrum

Stabilize feature `isolate_most_least_significant_one`

FCP completed #136909 (comment)

Closes #136909
@RalfJung

Copy link
Copy Markdown
Member

"std dev guide"? This is the first time I ever hear of that document.^^

@RalfJung

Copy link
Copy Markdown
Member

There's a bunch of material in the rustc dev guide that is primarily intended for std authors. I hope this doesn't get lost / needlessly duplicated. See e.g. https://rustc-dev-guide.rust-lang.org/stability.html

@okaneco
okaneco deleted the stabilize_iso_high_one branch April 12, 2026 18:26
@BoxyUwU BoxyUwU added the relnotes Marks issues that should be documented in the release notes of the next release. label Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking Issue for isolate_most_least_significant_one

7 participants