perf: skip irrelevant foreign impls when building the specialization graph - #157281
perf: skip irrelevant foreign impls when building the specialization graph#157281xmakro wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
290c594 to
52e8f33
Compare
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…<try> perf: Skip irrelevant foreign impls when building the specialization graph
|
💥 Test timed out after |
52e8f33 to
0eef947
Compare
|
@cjgillot could you please retry rust-timer |
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…<try> perf: skip irrelevant foreign impls when building the specialization graph
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (55fd877): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -2.2%, secondary -2.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -4.2%, secondary -8.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 517.006s -> 513.501s (-0.68%) |
0eef947 to
1ddeb9a
Compare
|
@cjgillot would you be comfortable reviewing this PR? or maybe someone from the types team? thanks! |
|
r? types |
|
cc @nnethercote who might be interested |
Skip foreign non-blanket impls that can't overlap any local impl when building the specialization graph. The call site showed up when profiling and this PR leads to a mean -1.5% instructions perf improvement, see #157281 (comment)