Skip to content

Move create_scope_map to rustc_codegen_ssa. - #157722

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
cjgillot:ssa-create-scope-map
Jun 12, 2026
Merged

Move create_scope_map to rustc_codegen_ssa.#157722
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
cjgillot:ssa-create-scope-map

Conversation

@cjgillot

@cjgillot cjgillot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

This resolves an old FIXME and allows to deduplicate code between LLVM and GCC.

@rustbot

rustbot commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

rustc_codegen_gcc is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_gcc instead.

cc @antoyo, @GuillaumeGomez

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 10, 2026
@rustbot

rustbot commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

r? @mu001999

rustbot has assigned @mu001999.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, debuginfo
  • compiler, debuginfo expanded to 73 candidates
  • Random selection from 17 candidates

@mu001999

mu001999 commented Jun 11, 2026

Copy link
Copy Markdown
Member

@rustbot reroll

@rustbot rustbot assigned oli-obk and unassigned mu001999 Jun 11, 2026
@oli-obk

oli-obk commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Oh it even avoids the recursion now, cool!

@bors r+ rollup

@rust-bors

rust-bors Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 5296ed3 has been approved by oli-obk

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 11, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157722 - cjgillot:ssa-create-scope-map, r=o…
860e78a 
…li-obk

Move create_scope_map to rustc_codegen_ssa.

This resolves an old FIXME and allows to deduplicate code between LLVM and GCC.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 11, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 11, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157722 - cjgillot:ssa-create-scope-map, r=o…
d5a9241 
…li-obk

Move create_scope_map to rustc_codegen_ssa.

This resolves an old FIXME and allows to deduplicate code between LLVM and GCC.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 11, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 11, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157722 - cjgillot:ssa-create-scope-map, r=o…
3ca5e27 
…li-obk

Move create_scope_map to rustc_codegen_ssa.

This resolves an old FIXME and allows to deduplicate code between LLVM and GCC.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 11, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 11, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157722 - cjgillot:ssa-create-scope-map, r=o…
e0156ea 
…li-obk

Move create_scope_map to rustc_codegen_ssa.

This resolves an old FIXME and allows to deduplicate code between LLVM and GCC.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 11, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 11, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157722 - cjgillot:ssa-create-scope-map, r=o…
a040b01 
…li-obk

Move create_scope_map to rustc_codegen_ssa.

This resolves an old FIXME and allows to deduplicate code between LLVM and GCC.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 11, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Jun 11, 2026
@bors
Auto merge of #157784 - JonathanBrouwer:rollup-AWfVuIL, r=JonathanBro…
516577b 
…uwer

Rollup of 23 pull requests

Successful merges:

 - #157716 (update Enzyme, June'26)
 - #149793 (Add inline asm support for amdgpu)
 - #152852 (Remove driver_lint_caps)
 - #155299 (make repr_transparent_non_zst_fields a hard error)
 - #155439 (Enable Cargo's new build-dir layout)
 - #157612 (Add a test where subtyping inhibits coercion.)
 - #157626 (Autogenerate unstable compiler flag stubs for unstable-book)
 - #157667 (Rename typing modes to better describe real usage)
 - #156212 (Additionally gate negative bounds behind new `-Zinternal-testing-features`)
 - #157342 (Reduce verbosity of cycle errors when possible)
 - #157366 (Add a regression test for an unconstrained TransmuteFrom ICE)
 - #157459 (rustc_target: callconv: powerpc64: Remove unreachable fallback code path)
 - #157658 (UnsafeCell: mention shared-ref-to-interior case, fix aliasing model inaccuracy)
 - #157698 (Remove an unnecessary cloning)
 - #157699 (Arg splat experiment - hir FnDecl impl)
 - #157713 (resolve: Remove exported imports from `maybe_unused_trait_imports`)
 - #157722 (Move create_scope_map to rustc_codegen_ssa.)
 - #157725 (Keep generic suggestion for macro-expanded missing-type items)
 - #157733 (Remove old FIXMEs about nocapture attribute)
 - #157737 (Reorganize `tests/ui/issues` [7/N])
 - #157746 (supports_c_variadic_definitions: extend checklist for new targets)
 - #157763 (Move unused target expression error to appropriate place and rename it)
 - #157768 (codegen_ssa: peel trans. wrappers on scalable vecs)
rust-bors Bot pushed a commit that referenced this pull request Jun 11, 2026
@bors
Auto merge of #157784 - JonathanBrouwer:rollup-AWfVuIL, r=JonathanBro…
13a88e0 
…uwer

Rollup of 23 pull requests

Successful merges:

 - #157716 (update Enzyme, June'26)
 - #149793 (Add inline asm support for amdgpu)
 - #152852 (Remove driver_lint_caps)
 - #155299 (make repr_transparent_non_zst_fields a hard error)
 - #155439 (Enable Cargo's new build-dir layout)
 - #157612 (Add a test where subtyping inhibits coercion.)
 - #157626 (Autogenerate unstable compiler flag stubs for unstable-book)
 - #157667 (Rename typing modes to better describe real usage)
 - #156212 (Additionally gate negative bounds behind new `-Zinternal-testing-features`)
 - #157342 (Reduce verbosity of cycle errors when possible)
 - #157366 (Add a regression test for an unconstrained TransmuteFrom ICE)
 - #157459 (rustc_target: callconv: powerpc64: Remove unreachable fallback code path)
 - #157658 (UnsafeCell: mention shared-ref-to-interior case, fix aliasing model inaccuracy)
 - #157698 (Remove an unnecessary cloning)
 - #157699 (Arg splat experiment - hir FnDecl impl)
 - #157713 (resolve: Remove exported imports from `maybe_unused_trait_imports`)
 - #157722 (Move create_scope_map to rustc_codegen_ssa.)
 - #157725 (Keep generic suggestion for macro-expanded missing-type items)
 - #157733 (Remove old FIXMEs about nocapture attribute)
 - #157737 (Reorganize `tests/ui/issues` [7/N])
 - #157746 (supports_c_variadic_definitions: extend checklist for new targets)
 - #157763 (Move unused target expression error to appropriate place and rename it)
 - #157768 (codegen_ssa: peel trans. wrappers on scalable vecs)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jun 11, 2026
@JonathanBrouwer
Rollup merge of rust-lang#157722 - cjgillot:ssa-create-scope-map, r=o…
59a09f9 
…li-obk

Move create_scope_map to rustc_codegen_ssa.

This resolves an old FIXME and allows to deduplicate code between LLVM and GCC.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jun 11, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Jun 11, 2026
@bors
Auto merge of #157790 - JonathanBrouwer:rollup-VINajy8, r=JonathanBro…
88446ba 
…uwer

Rollup of 23 pull requests

Successful merges:

 - #157716 (update Enzyme, June'26)
 - #149793 (Add inline asm support for amdgpu)
 - #155299 (make repr_transparent_non_zst_fields a hard error)
 - #155439 (Enable Cargo's new build-dir layout)
 - #157612 (Add a test where subtyping inhibits coercion.)
 - #157626 (Autogenerate unstable compiler flag stubs for unstable-book)
 - #157667 (Rename typing modes to better describe real usage)
 - #149749 (Make `BorrowedBuf` and `BorrowedCursor` generic over the data)
 - #156212 (Additionally gate negative bounds behind new `-Zinternal-testing-features`)
 - #157342 (Reduce verbosity of cycle errors when possible)
 - #157366 (Add a regression test for an unconstrained TransmuteFrom ICE)
 - #157459 (rustc_target: callconv: powerpc64: Remove unreachable fallback code path)
 - #157658 (UnsafeCell: mention shared-ref-to-interior case, fix aliasing model inaccuracy)
 - #157698 (Remove an unnecessary cloning)
 - #157699 (Arg splat experiment - hir FnDecl impl)
 - #157713 (resolve: Remove exported imports from `maybe_unused_trait_imports`)
 - #157722 (Move create_scope_map to rustc_codegen_ssa.)
 - #157725 (Keep generic suggestion for macro-expanded missing-type items)
 - #157733 (Remove old FIXMEs about nocapture attribute)
 - #157737 (Reorganize `tests/ui/issues` [7/N])
 - #157746 (supports_c_variadic_definitions: extend checklist for new targets)
 - #157763 (Move unused target expression error to appropriate place and rename it)
 - #157768 (codegen_ssa: peel trans. wrappers on scalable vecs)
@jhpratt jhpratt mentioned this pull request Jun 12, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Jun 12, 2026
@bors
Auto merge of #157794 - jhpratt:rollup-TxFk7Q6, r=jhpratt
09a3713 
Rollup of 24 pull requests

Successful merges:

 - #157716 (update Enzyme, June'26)
 - #149793 (Add inline asm support for amdgpu)
 - #155299 (make repr_transparent_non_zst_fields a hard error)
 - #157612 (Add a test where subtyping inhibits coercion.)
 - #157626 (Autogenerate unstable compiler flag stubs for unstable-book)
 - #157667 (Rename typing modes to better describe real usage)
 - #149749 (Make `BorrowedBuf` and `BorrowedCursor` generic over the data)
 - #155113 (Ensure Send/Sync impl for std::process::CommandArgs)
 - #156212 (Additionally gate negative bounds behind new `-Zinternal-testing-features`)
 - #157342 (Reduce verbosity of cycle errors when possible)
 - #157366 (Add a regression test for an unconstrained TransmuteFrom ICE)
 - #157459 (rustc_target: callconv: powerpc64: Remove unreachable fallback code path)
 - #157658 (UnsafeCell: mention shared-ref-to-interior case, fix aliasing model inaccuracy)
 - #157698 (Remove an unnecessary cloning)
 - #157699 (Arg splat experiment - hir FnDecl impl)
 - #157713 (resolve: Remove exported imports from `maybe_unused_trait_imports`)
 - #157722 (Move create_scope_map to rustc_codegen_ssa.)
 - #157723 (Move uninhabited unreachable code lint to rustc_mir_transform)
 - #157725 (Keep generic suggestion for macro-expanded missing-type items)
 - #157733 (Remove old FIXMEs about nocapture attribute)
 - #157737 (Reorganize `tests/ui/issues` [7/N])
 - #157746 (supports_c_variadic_definitions: extend checklist for new targets)
 - #157763 (Move unused target expression error to appropriate place and rename it)
 - #157768 (codegen_ssa: peel trans. wrappers on scalable vecs)
@rust-bors
rust-bors Bot merged commit c454aae into rust-lang:main Jun 12, 2026
12 checks passed
@rustbot rustbot added this to the 1.98.0 milestone Jun 12, 2026
@cjgillot
cjgillot deleted the ssa-create-scope-map branch June 12, 2026 10:31
pull Bot pushed a commit to xtqqczze/rust-lang-miri that referenced this pull request Jun 13, 2026
@bors
Auto merge of #157794 - jhpratt:rollup-TxFk7Q6, r=jhpratt
deb515f 
Rollup of 24 pull requests

Successful merges:

 - rust-lang/rust#157716 (update Enzyme, June'26)
 - rust-lang/rust#149793 (Add inline asm support for amdgpu)
 - rust-lang/rust#155299 (make repr_transparent_non_zst_fields a hard error)
 - rust-lang/rust#157612 (Add a test where subtyping inhibits coercion.)
 - rust-lang/rust#157626 (Autogenerate unstable compiler flag stubs for unstable-book)
 - rust-lang/rust#157667 (Rename typing modes to better describe real usage)
 - rust-lang/rust#149749 (Make `BorrowedBuf` and `BorrowedCursor` generic over the data)
 - rust-lang/rust#155113 (Ensure Send/Sync impl for std::process::CommandArgs)
 - rust-lang/rust#156212 (Additionally gate negative bounds behind new `-Zinternal-testing-features`)
 - rust-lang/rust#157342 (Reduce verbosity of cycle errors when possible)
 - rust-lang/rust#157366 (Add a regression test for an unconstrained TransmuteFrom ICE)
 - rust-lang/rust#157459 (rustc_target: callconv: powerpc64: Remove unreachable fallback code path)
 - rust-lang/rust#157658 (UnsafeCell: mention shared-ref-to-interior case, fix aliasing model inaccuracy)
 - rust-lang/rust#157698 (Remove an unnecessary cloning)
 - rust-lang/rust#157699 (Arg splat experiment - hir FnDecl impl)
 - rust-lang/rust#157713 (resolve: Remove exported imports from `maybe_unused_trait_imports`)
 - rust-lang/rust#157722 (Move create_scope_map to rustc_codegen_ssa.)
 - rust-lang/rust#157723 (Move uninhabited unreachable code lint to rustc_mir_transform)
 - rust-lang/rust#157725 (Keep generic suggestion for macro-expanded missing-type items)
 - rust-lang/rust#157733 (Remove old FIXMEs about nocapture attribute)
 - rust-lang/rust#157737 (Reorganize `tests/ui/issues` [7/N])
 - rust-lang/rust#157746 (supports_c_variadic_definitions: extend checklist for new targets)
 - rust-lang/rust#157763 (Move unused target expression error to appropriate place and rename it)
 - rust-lang/rust#157768 (codegen_ssa: peel trans. wrappers on scalable vecs)
@Firestar99 Firestar99 mentioned this pull request Jun 25, 2026
Open
rust-bors Bot pushed a commit that referenced this pull request Jul 24, 2026
@jhpratt
Rollup merge of #157722 - cjgillot:ssa-create-scope-map, r=oli-obk
ab8c5d5 
Move create_scope_map to rustc_codegen_ssa.

This resolves an old FIXME and allows to deduplicate code between LLVM and GCC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obk oli-obk

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.98.0

Development

Successfully merging this pull request may close these issues.

4 participants

@cjgillot @rustbot @mu001999 @oli-obk