rustdoc: Fix crash when trying to list attributes on an opaque type - #160208
Merged
Conversation
rustbot
added
S-waiting-on-review
Contributor
|
This isn't the real solution. You should be able to search the traits that the opaque type implements. I've pushed a test case to your branch that demonstrates the problem. Instead, make |
rustbot
added
A-rustdoc-js
rustbot
removed
the
S-waiting-on-review
Contributor
|
Wait, I'm an idiot. It's working fine. I just wrote the test case wrong. I've pushed a new test case that actually tests this correctly. |
rustbot
added
the
S-waiting-on-review
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 31, 2026
rustdoc: Fix crash when trying to list attributes on an opaque type Fixes rust-lang#160107. It's crashing because we're using `get_attrs` on an `OpaqueTy` which cannot have attributes and therefore crashed. So instead, I check ahead of calling this function in the path where this can happen instead of doing it in `convert_render_type_id` on all `RenderTypeId::DefId`. r? @notriddle
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 31, 2026
rustdoc: Fix crash when trying to list attributes on an opaque type Fixes rust-lang#160107. It's crashing because we're using `get_attrs` on an `OpaqueTy` which cannot have attributes and therefore crashed. So instead, I check ahead of calling this function in the path where this can happen instead of doing it in `convert_render_type_id` on all `RenderTypeId::DefId`. r? @notriddle
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 31, 2026
rustdoc: Fix crash when trying to list attributes on an opaque type Fixes rust-lang#160107. It's crashing because we're using `get_attrs` on an `OpaqueTy` which cannot have attributes and therefore crashed. So instead, I check ahead of calling this function in the path where this can happen instead of doing it in `convert_render_type_id` on all `RenderTypeId::DefId`. r? @notriddle
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 31, 2026
…uwer Rollup of 21 pull requests Successful merges: - #160100 (Add "system" option to `override-allocator` directive) - #159675 (rustc: Support `--jobs` options for limiting parallelism in various parts of the compiler) - #159999 (Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends) - #160233 (Bubble bad path error while parsing field to avoid unecessary second error) - #160272 (rustc_metadata: Move native library search code to `rustc_codegen_ssa`) - #154202 (rustfmt: Format `cfg_select!`) - #158835 (rustc_passes: lint unused `#[path]` attributes on inline modules) - #159520 (Suggest `Vec<T>` instead of `[T]`) - #160034 (Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser) - #160066 (rustc_middle: lint attribute cleanups) - #160085 (Remove various superfluous lint attributes) - #160113 (Coalesce `rustc_on_unimplemented` attributes and lint malformed filters) - #160119 (fix query cycle in `coroutine_hidden_types` for the next solver) - #160147 (tests: Remove `-Zthreads` options from tests in `ui/parallel-rustc`) - #160157 (Remove outdated comments from `va_list.rs`) - #160159 (More accurately check for interior mutability in `invalid_reference_casting` lint) - #160208 (rustdoc: Fix crash when trying to list attributes on an opaque type) - #160244 (Rename splat to rustc_splat in error messages) - #160246 (dont fire `unused_mut` on `&pin mut self`) - #160247 (Configure backport nominations for rustfmt) - #160274 (renovate: update lock files weekly)
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 31, 2026
…uwer Rollup of 22 pull requests Successful merges: - #160100 (Add "system" option to `override-allocator` directive) - #160220 (Refactor: shrink region ext traits) - #159675 (rustc: Support `--jobs` options for limiting parallelism in various parts of the compiler) - #159999 (Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends) - #160233 (Bubble bad path error while parsing field to avoid unecessary second error) - #160272 (rustc_metadata: Move native library search code to `rustc_codegen_ssa`) - #154202 (rustfmt: Format `cfg_select!`) - #159520 (Suggest `Vec<T>` instead of `[T]`) - #159710 (Add rustdoc/cargo PGO profiles to reproducible artifacts) - #160034 (Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser) - #160066 (rustc_middle: lint attribute cleanups) - #160085 (Remove various superfluous lint attributes) - #160113 (Coalesce `rustc_on_unimplemented` attributes and lint malformed filters) - #160119 (fix query cycle in `coroutine_hidden_types` for the next solver) - #160147 (tests: Remove `-Zthreads` options from tests in `ui/parallel-rustc`) - #160157 (Remove outdated comments from `va_list.rs`) - #160159 (More accurately check for interior mutability in `invalid_reference_casting` lint) - #160208 (rustdoc: Fix crash when trying to list attributes on an opaque type) - #160244 (Rename splat to rustc_splat in error messages) - #160246 (dont fire `unused_mut` on `&pin mut self`) - #160247 (Configure backport nominations for rustfmt) - #160274 (renovate: update lock files weekly)
rust-timer
added a commit
that referenced
this pull request
Jul 31, 2026
Rollup merge of #160208 - GuillaumeGomez:opaque-ty, r=notriddle rustdoc: Fix crash when trying to list attributes on an opaque type Fixes #160107. It's crashing because we're using `get_attrs` on an `OpaqueTy` which cannot have attributes and therefore crashed. So instead, I check ahead of calling this function in the path where this can happen instead of doing it in `convert_render_type_id` on all `RenderTypeId::DefId`. r? @notriddle
github-actions Bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Aug 3, 2026
…uwer Rollup of 22 pull requests Successful merges: - rust-lang/rust#160100 (Add "system" option to `override-allocator` directive) - rust-lang/rust#160220 (Refactor: shrink region ext traits) - rust-lang/rust#159675 (rustc: Support `--jobs` options for limiting parallelism in various parts of the compiler) - rust-lang/rust#159999 (Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends) - rust-lang/rust#160233 (Bubble bad path error while parsing field to avoid unecessary second error) - rust-lang/rust#160272 (rustc_metadata: Move native library search code to `rustc_codegen_ssa`) - rust-lang/rust#154202 (rustfmt: Format `cfg_select!`) - rust-lang/rust#159520 (Suggest `Vec<T>` instead of `[T]`) - rust-lang/rust#159710 (Add rustdoc/cargo PGO profiles to reproducible artifacts) - rust-lang/rust#160034 (Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser) - rust-lang/rust#160066 (rustc_middle: lint attribute cleanups) - rust-lang/rust#160085 (Remove various superfluous lint attributes) - rust-lang/rust#160113 (Coalesce `rustc_on_unimplemented` attributes and lint malformed filters) - rust-lang/rust#160119 (fix query cycle in `coroutine_hidden_types` for the next solver) - rust-lang/rust#160147 (tests: Remove `-Zthreads` options from tests in `ui/parallel-rustc`) - rust-lang/rust#160157 (Remove outdated comments from `va_list.rs`) - rust-lang/rust#160159 (More accurately check for interior mutability in `invalid_reference_casting` lint) - rust-lang/rust#160208 (rustdoc: Fix crash when trying to list attributes on an opaque type) - rust-lang/rust#160244 (Rename splat to rustc_splat in error messages) - rust-lang/rust#160246 (dont fire `unused_mut` on `&pin mut self`) - rust-lang/rust#160247 (Configure backport nominations for rustfmt) - rust-lang/rust#160274 (renovate: update lock files weekly)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160107.
It's crashing because we're using
get_attrson anOpaqueTywhich cannot have attributes and therefore crashed. So instead, I check ahead of calling this function in the path where this can happen instead of doing it inconvert_render_type_idon allRenderTypeId::DefId.r? @notriddle