Skip to content

Remove redundant target check from check_eii_impl - #160409

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
sethryanrollins:sethr/issue-153101/check_eii_impl
Aug 3, 2026
Merged

Remove redundant target check from check_eii_impl#160409
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
sethryanrollins:sethr/issue-153101/check_eii_impl

Conversation

@sethryanrollins

Copy link
Copy Markdown
Contributor

Part of #131229 which is the parent issue of #153101

Signed-off-by: Seth Rollins <sethryanrollins@gmail.com>
@rustbot

rustbot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 3, 2026
@rustbot

rustbot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 20 candidates

Comment thread compiler/rustc_passes/src/check_attr.rs

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors

rust-bors Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f1d777a has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2026
rust-bors Bot pushed a commit that referenced this pull request Aug 3, 2026
Rollup of 5 pull requests

Successful merges:

 - #160143 (Add NEON support for is_ascii and eq_ignore_ascii_case)
 - #160191 (bootstrap: Don't pass `Kind` to some places that don't need it)
 - #160386 (rustc_data_structures: Cleanup jobserver initialization)
 - #160409 (Remove redundant target check from check_eii_impl)
 - #160410 (Update GitHub Actions to v7.0.1)
@rust-bors
rust-bors Bot merged commit dd32818 into rust-lang:main Aug 3, 2026
13 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Aug 3, 2026
rust-timer added a commit that referenced this pull request Aug 3, 2026
Rollup merge of #160409 - sethryanrollins:sethr/issue-153101/check_eii_impl, r=jieyouxu

Remove redundant target check from check_eii_impl

Part of #131229 which is the parent issue of #153101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants