Skip to content

Rollup of 3 pull requests - #160414

Merged
rust-bors[bot] merged 7 commits into
rust-lang:mainfrom
jhpratt:rollup-bSKtJ4G
Aug 3, 2026
Merged

Rollup of 3 pull requests#160414
rust-bors[bot] merged 7 commits into
rust-lang:mainfrom
jhpratt:rollup-bSKtJ4G

Conversation

@jhpratt

@jhpratt jhpratt commented Aug 3, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

saethlin and others added 7 commits August 1, 2026 14:34
…, r=bjorn3

Don't use exported generics from conditional dependencies (panic runtimes and profiler-builtins)

This is a fix for rust-lang#159682.

This seems like a generalized footgun for writing FFI plugins? But at least right now, a very specific change to the crates we often swap around seems prudent.
Rerun the goal with doubled recursion limit even if the goal has ty vars

Fix the `bevy_render` regression and more in the next solver crater run.

The problem is that we don't rerun the root goal with doubled recursion limit if it contains ty vars.
But we actually need the evaluation response to resolve the ty vars. So the type inference fails.
…t, r=khyperia

Improve the test for patterns in fn pointers

Follow up of rust-lang#160282
The goal is to cover more cases of the behaviour of patterns in fn pointers.
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label Aug 3, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Aug 3, 2026
@jhpratt

jhpratt commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

@bors r+ rollup=never p=5

@rust-bors

rust-bors Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 9e756da has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2026
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@jhpratt

jhpratt commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

spurious; letting run continue

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 3, 2026
Rollup of 3 pull requests

Successful merges:

 - #160306 (Don't use exported generics from conditional dependencies (panic runtimes and profiler-builtins))
 - #160254 (Rerun the goal with doubled recursion limit even if the goal has ty vars)
 - #160380 (Improve the test for patterns in fn pointers)
@rust-bors rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 3, 2026
@rust-bors

rust-bors Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

💔 Test for a182dd9 failed: CI. Failed job:

@jhpratt

jhpratt commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

@bors treeclosed=5 spurious failures

@bors retry

@rust-bors

rust-bors Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Tree closed for PRs with priority less than 5.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 3, 2026
@rust-bors

This comment has been minimized.

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@JonathanBrouwer

Copy link
Copy Markdown
Contributor

@bors treeopen

@rust-bors

rust-bors Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Tree is now open for merging.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 3, 2026
@rust-bors

rust-bors Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 11m 26s
Pushing 7c329d6 to main...

@rust-bors
rust-bors Bot merged commit 7c329d6 into rust-lang:main Aug 3, 2026
3 of 14 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Aug 3, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#160306 Don't use exported generics from conditional dependencies (… afa89e1bca83b15cd32ab43c762db9dd2f343e0c (link)
#160254 Rerun the goal with doubled recursion limit even if the goa… 0a20f67f58f79b5719070d66e2e8679281002182 (link)
#160380 Improve the test for patterns in fn pointers aad2d2b627e669673a3643b558b547ab8e6952ae (link)

previous master: 65dd30fb9e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 65dd30f (parent) -> 7c329d6 (this PR)

Test differences

Show 6 test diffs

Stage 1

  • [ui] tests/ui/traits/next-solver/overflow-discards-constraints.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/traits/next-solver/overflow-discards-constraints.rs: [missing] -> pass (J2)

Stage 2

  • [ui] tests/ui/traits/next-solver/overflow-discards-constraints.rs: [missing] -> pass (J1)

Additionally, 3 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 7c329d6c76e11ca40c5673818ab0439c1be8962c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu: 1h 46m -> 2h 38m (+49.0%)
  2. armhf-gnu: 1h 3m -> 1h 33m (+47.9%)
  3. dist-powerpc-linux: 1h 7m -> 1h 34m (+40.0%)
  4. x86_64-gnu-gcc: 48m 45s -> 1h 7m (+38.1%)
  5. dist-x86_64-solaris: 1h 12m -> 1h 37m (+34.6%)
  6. x86_64-gnu-next-trait-solver-polonius: 1h 1m -> 41m 23s (-32.3%)
  7. dist-riscv64-linux-gnu: 1h 10m -> 1h 31m (+30.7%)
  8. dist-i686-linux: 1h 25m -> 1h 51m (+30.5%)
  9. x86_64-gnu-aux: 2h 2m -> 2h 35m (+26.9%)
  10. dist-x86_64-linux-alt: 1h 53m -> 2h 23m (+26.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants