Skip to content

implement -Zllvm-target-feature - #160457

Open
RalfJung wants to merge 2 commits into
rust-lang:mainfrom
RalfJung:llvm-target-feature
Open

implement -Zllvm-target-feature#160457
RalfJung wants to merge 2 commits into
rust-lang:mainfrom
RalfJung:llvm-target-feature

Conversation

@RalfJung

@RalfJung RalfJung commented Aug 3, 2026

Copy link
Copy Markdown
Member

Implements #157753

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 3, 2026
@rustbot

rustbot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 19 candidates

@RalfJung RalfJung mentioned this pull request Aug 3, 2026
Draft
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@RalfJung
RalfJung force-pushed the llvm-target-feature branch from 4e5c003 to 7da31f0 Compare August 3, 2026 18:12
@ojeda ojeda mentioned this pull request Aug 3, 2026
Open
52 tasks
folkertdev
folkertdev reviewed Aug 3, 2026
View reviewed changes

@folkertdev folkertdev left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comment nits, r=me when resolved to your satisfaction

View changes since this review

Comment thread compiler/rustc_codegen_llvm/src/llvm_util.rs Outdated
Comment thread compiler/rustc_session/src/options.rs Outdated
@RalfJung
RalfJung force-pushed the llvm-target-feature branch 2 times, most recently from 1edb5a0 to 2df3a43 Compare August 3, 2026 20:13
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@RalfJung
RalfJung force-pushed the llvm-target-feature branch 2 times, most recently from 46ca706 to dcab1e0 Compare August 3, 2026 20:26
@RalfJung

RalfJung commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

@folkertdev sorry I had missed your review and have done a bit more clarification on the comment about only_base_features, and also renamed that variable. I can undo that if you prefer, or could you take another look?

folkertdev
folkertdev approved these changes Aug 3, 2026
View reviewed changes

@folkertdev folkertdev left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, r=me when CI is green

View changes since this review

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@RalfJung

RalfJung commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

@GuillaumeGomez @antoyo any idea why GCC complains about retain now...?

@antoyo

antoyo commented Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

There was an issue in the last sync. The PR is currently being reverted.

@RalfJung

RalfJung commented Aug 3, 2026

Copy link
Copy Markdown
Member Author

Oh it did the same in #160372 (comment).
Seems like something broke about that job and now all PR CI fails? How is that even possible?

@antoyo

antoyo commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Seems like something broke about that job and now all PR CI fails? How is that even possible?

That's something we'd like to know: how can the tests pass in PR, then fails afterwards?

@RalfJung

RalfJung commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

@bors r=folkertdev

@rust-bors

rust-bors Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

📌 Commit dcab1e0 has been approved by folkertdev

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2026
@RalfJung
RalfJung force-pushed the llvm-target-feature branch from dcab1e0 to c82207c Compare August 4, 2026 09:26
@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 4, 2026
@rust-bors rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 4, 2026
@rustbot

rustbot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-bors

rust-bors Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

⚠️ A new commit c82207c46e5cefe4ddb000232aec281c28f0f6a8 was pushed.

This pull request was unapproved.

@RalfJung

RalfJung commented Aug 4, 2026

Copy link
Copy Markdown
Member Author

I just rebased to get clean PR CI.
@bors r=folkertdev

@rust-bors

rust-bors Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c82207c has been approved by folkertdev

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened.

Reason for tree closure: manually handling queue due to backlog

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 4, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 4, 2026
@JonathanBrouwer
Rollup merge of rust-lang#160457 - RalfJung:llvm-target-feature, r=fo…
75fad49 
…lkertdev

implement -Zllvm-target-feature

Implements rust-lang#157753
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 4, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 4, 2026
@JonathanBrouwer
Rollup merge of rust-lang#160457 - RalfJung:llvm-target-feature, r=fo…
4182867 
…lkertdev

implement -Zllvm-target-feature

Implements rust-lang#157753
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 4, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@folkertdev folkertdev folkertdev approved these changes

Assignees

@folkertdev folkertdev

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RalfJung @rustbot @rust-log-analyzer @antoyo @folkertdev