Use VisitorResult helper macros - #160568
Merged
Merged
Conversation
.. so that you don't need to import `TypeVisitable` in order to use it. I used the `TypeVisitable` from `rustc_type_ir` and not `rustc_middle::ty` because the macro is called inside `rustc_type_ir` itself.
.. instead of hand-rolling our own
rustbot
added
the
S-waiting-on-review
rustbot
added
the
T-compiler
Collaborator
|
|
jdonszelmann
reviewed
Aug 6, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 6, 2026
…nszelmann Use `VisitorResult` helper macros .. instead of hand-rolling our own r? @jdonszelmann
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 6, 2026
…nszelmann Use `VisitorResult` helper macros .. instead of hand-rolling our own r? @jdonszelmann
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 6, 2026
…nszelmann Use `VisitorResult` helper macros .. instead of hand-rolling our own r? @jdonszelmann
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 6, 2026
…nszelmann Use `VisitorResult` helper macros .. instead of hand-rolling our own r? @jdonszelmann
This was referenced Aug 6, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 6, 2026
…uwer Rollup of 17 pull requests Successful merges: - #159530 (Cap socket send length to c_int::MAX on Apple targets) - #159506 (Allow associated const equality constraints with GCA) - #160006 (Account for desugaring in method call move errors) - #160415 (Split `aarch64-apple{,-macos-26}` => `aarch64-apple{,-macos-26}-{1,2}` jobs) - #160464 (fix: Check the fallback map before queueing child in `visible_parent_map` breadth-first search) - #160555 (Split `apply_primary_terminator_effect`) - #160592 (Suggest if-let chain continuation on unclosed delimiter) - #160600 (Avoid the std DLL copy alongside rustc) - #160156 (check_consts: exhaustively match on CastKind) - #160211 (Rename `#[unroll]` => `#[rustc_unroll]` to mitigate nameres ambiguity) - #160304 (Add tests for fixed new solver issues) - #160398 (rustc_abi: Add `LayoutData::is_variant_uninhabited` method) - #160546 (Update error message in documentation comments) - #160568 (Use `VisitorResult` helper macros) - #160571 (Add regression test for array type recovery in generic arguments) - #160588 (add a test showing polonius alpha is not a subset of datalog polonius) - #160617 (Add a suggestion to MissingUnsafeOnExtern diagnostic)
rust-timer
added a commit
that referenced
this pull request
Aug 6, 2026
Rollup merge of #160568 - ada4a:ada/push-vklwmykymnxk, r=jdonszelmann Use `VisitorResult` helper macros .. instead of hand-rolling our own r? @jdonszelmann
Contributor
|
@rust-timer build bd700c5 |
Collaborator
|
Queued bd700c5 with parent 887804d, future comparison URL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.. instead of hand-rolling our own
r? @jdonszelmann